Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.0.2] compatibility with Symfony 4 #316

Closed
remicollet opened this issue Jan 3, 2022 · 8 comments
Closed

[6.0.2] compatibility with Symfony 4 #316

remicollet opened this issue Jan 3, 2022 · 8 comments
Assignees
@llaville

Comments

@remicollet
Copy link
Contributor

regression #310 is back

The fix is in master but not in 6.0 branch

PHP Fatal error: Declaration of Bartlett\CompatInfo\Application\Event\Dispatcher\EventDispatcher::dispatch(object $event, ?string $eventName = null): object must be compatible with Symfony\Component\EventDispatcher\EventDispatcher::dispatch($event) in ...
@remicollet
Copy link
Contributor Author

Fix for #309 is also missing...

@llaville llaville self-assigned this Jan 3, 2022
@llaville
Copy link
Owner

llaville commented Jan 3, 2022

Thanks for reporting, I'll fix it now

@llaville
Copy link
Owner

llaville commented Jan 3, 2022

Two commits (fixes) was git cherry-picked from master branch to synchronize branch 6.0

@remicollet
Copy link
Contributor Author

Also missing in 6.1 branch ?

@llaville
Copy link
Owner

llaville commented Jan 3, 2022

no, I've just checked it

@llaville
Copy link
Owner

llaville commented Jan 3, 2022

FYI: I plan to release the v6.1.0 in 3 days

@llaville
Copy link
Owner

llaville commented Jan 4, 2022

@remicollet FYI (#317) ; php-compatinfo-db 3.17.0 will be released tomorrow

@llaville
Copy link
Owner

llaville commented Jan 4, 2022

Feel free to reopen this issue, if you think I've missed something

@llaville llaville closed this as completed Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@llaville llaville

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@remicollet @llaville