Fix imageView animation for bounds change #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkzhao
force-pushed
the
content-mode-fix
branch
2 times, most recently
from
c527846 to
8135091
Compare
lkzhao
force-pushed
the
content-mode-fix
branch
from
8135091 to
b6359f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before & After:
Fix #10!
Before this patch, imageViews are treated equally with all the other views.
Snapshots are taken before animation starts. During the animation the image will be distorted if their bounds change. Even though the cross fade effect reduce the noticeability, it is still a bit rough.
With this patch. ImageView transitions is smoother. ContentModes like
aspectFillis being enforced even during animations.I also added another non-square image into the examples to test and demonstrate this.