Fleshed out tests for Symbol.matchAll, String.p.matchAll, RegExp.p[@@…

…matchall], and %RegExpStringIteratorPrototype%

Tests were updated and assuming tc39/proposal-string-matchall#33 will be merged.

features.txt

@@ -72,6 +72,11 @@ String.prototype.trimStart
 # https://github.com/tc39/proposal-numeric-separator
 numeric-separator-literal
 
+# String.prototype.matchAll
+# https://github.com/tc39/proposal-string-matchall
+String.prototype.matchAll
+Symbol.matchAll
+
 # Standard language features
 #
 # Language features that have been included in a published version of the

harness/compareIterator.js

@@ -0,0 +1,34 @@
+// Copyright (C) 2018 Peter Wong.  All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+description: Compare the values of an iterator with an array of expected values
+---*/
+
+// Example:
+//
+//    function* numbers() {
+//      yield 1;
+//      yield 2;
+//      yield 3;
+//    }
+//
+//    compareIterator(numbers(), [
+//      v => assert.sameValue(v, 1),
+//      v => assert.sameValue(v, 2),
+//      v => assert.sameValue(v, 3),
+//    ]);
+//
+assert.compareIterator = function(iter, validators, message) {
+  message = message || '';
+
+  var i, result;
+  for (i = 0; i < validators.length; i++) {
+    result = iter.next();
+    assert(!result.done, 'Expected ' + i + ' values(s). Instead iterator only produced ' + (i - 1) + ' value(s). ' + message);
+    validators[i](result.value);
+  }
+
+  result = iter.next();
+  assert(result.done, 'Expected only ' + i + ' values(s). Instead iterator produced more. ' + message);
+  assert.sameValue(result.value, undefined, 'Expected value of `undefined` when iterator completes. ' + message);
+}

harness/regExpUtils.js

@@ -37,3 +37,18 @@ function testPropertyEscapes(regex, string, expression) {
     }
   }
 }
+
+// Returns a function that will validate RegExp match result
+//
+// Example:
+//
+//    var validate = matchValidator(['b'], 1, 'abc');
+//    validate(/b/.exec('abc'));
+//
+function matchValidator(expectedEntries, expectedIndex, expectedInput) {
+  return function(match) {
+    assert.compareArray(match, expectedEntries, 'Match entries');
+    assert.sameValue(match.index, expectedIndex, 'Match index');
+    assert.sameValue(match.input, expectedInput, 'Match input');
+  }
+}

test/built-ins/RegExp/prototype/Symbol.matchAll/internal-regexp-lastindex-not-zero.js

@@ -0,0 +1,33 @@
+// Copyright (C) 2018 Peter Wong. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: pending
+description: |
+  Throws TypeError when internally created RegExp's lastIndex is not 0
+info: |
+  RegExp.prototype [ @@matchAll ] ( string )
+    [...]
+    3. Return ? MatchAllIterator(R, string).
+
+  MatchAllIterator ( R, O )
+    [...]
+    2. If ? IsRegExp(R) is true, then
+      [...]
+    3. Else,
+      a. Let matcher be RegExpCreate(R, "g").
+      b. If ? IsRegExp(matcher) is not true, throw a TypeError exception.
+      [...]
+      3. If Get(matcher, "lastIndex") is not 0, throw a TypeError exception.
+features: [Symbol.match, Symbol.matchAll]
+---*/
+
+Object.defineProperty(RegExp.prototype, Symbol.match, {
+  get() {
+    this.lastIndex = 1;
+    return true;
+  }
+});
+
+assert.throws(TypeError, function() {
+  RegExp.prototype[Symbol.matchAll].call({}, '');
+});

test/built-ins/RegExp/prototype/Symbol.matchAll/isregexp-internal-regexp-is-false.js

@@ -0,0 +1,29 @@
+// Copyright (C) 2018 Peter Wong. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: pending
+description: Throws TypeError when internally created RegExp's @@match is false
+info: |
+  RegExp.prototype [ @@matchAll ] ( string )
+    [...]
+    3. Return ? MatchAllIterator(R, string).
+
+  MatchAllIterator ( R, O )
+    [...]
+    2. If ? IsRegExp(R) is true, then
+      [...]
+    3. Else,
+      a. Let matcher be RegExpCreate(R, "g").
+      b. If ? IsRegExp(matcher) is not true, throw a TypeError exception.
+features: [Symbol.match, Symbol.matchAll]
+---*/
+
+Object.defineProperty(RegExp.prototype, Symbol.match, {
+  get() {
+    return false;
+  }
+});
+
+assert.throws(TypeError, function() {
+  RegExp.prototype[Symbol.matchAll].call({}, '');
+});

test/built-ins/RegExp/prototype/Symbol.matchAll/isregexp-internal-regexp-throws.js

@@ -0,0 +1,29 @@
+// Copyright (C) 2018 Peter Wong. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: pending
+description: Re-throws errors thrown while accessing @@match property
+info: |
+  RegExp.prototype [ @@matchAll ] ( string )
+    [...]
+    3. Return ? MatchAllIterator(R, string).
+
+  MatchAllIterator ( R, O )
+    [...]
+    2. If ? IsRegExp(R) is true, then
+      [...]
+    3. Else,
+      a. Let matcher be RegExpCreate(R, "g").
+      b. If ? IsRegExp(matcher) is not true, throw a TypeError exception.
+features: [Symbol.match, Symbol.matchAll]
+---*/
+
+Object.defineProperty(RegExp.prototype, Symbol.match, {
+  get() {
+    throw new Test262Error();
+  }
+});
+
+assert.throws(Test262Error, function() {
+  RegExp.prototype[Symbol.matchAll].call({}, '');
+});

test/built-ins/RegExp/prototype/Symbol.matchAll/isregexp-this-throws.js

@@ -0,0 +1,26 @@
+// Copyright (C) 2018 Peter Wong. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: pending
+description: Re-throws errors thrown while accessing RegExp's @@match property
+info: |
+  RegExp.prototype [ @@matchAll ] ( string )
+    [...]
+    3. Return ? MatchAllIterator(R, string).
+
+  MatchAllIterator ( R, O )
+    [...]
+    2. If ? IsRegExp(R) is true, then
+      [...]
+features: [Symbol.match, Symbol.matchAll]
+---*/
+
+var obj = {
+  get [Symbol.match]() {
+    throw new Test262Error();
+  }
+};
+
+assert.throws(Test262Error, function() {
+  RegExp.prototype[Symbol.matchAll].call(obj, '');
+});

test/built-ins/RegExp/prototype/Symbol.matchAll/length.js

@@ -1,17 +1,22 @@
 // Copyright (C) 2018 Jordan Harband. All rights reserved.
 // This code is governed by the BSD license found in the LICENSE file.
 /*---
+esid: pending
 description: RegExp.prototype[Symbol.matchAll] `length` property
 info: |
-    ES6 Section 17:
-    Every built-in Function object, including constructors, has a length
-    property whose value is an integer. Unless otherwise specified, this value
-    is equal to the largest number of named arguments shown in the subclause
-    headings for the function description, including optional parameters.
+  17 ECMAScript Standard Built-in Objects:
 
     [...]
 
-    Unless otherwise specified, the length property of a built-in Function
+    Every built-in function object, including constructors, has a length
+    property whose value is an integer. Unless otherwise specified, this
+    value is equal to the largest number of named arguments shown in the
+    subclause headings for the function description. Optional parameters
+    (which are indicated with brackets: [ ]) or rest parameters (which
+    are shown using the form «...name») are not included in the default
+    argument count.
+
+    Unless otherwise specified, the length property of a built-in function
     object has the attributes { [[Writable]]: false, [[Enumerable]]: false,
     [[Configurable]]: true }.
 includes: [propertyHelper.js]

test/built-ins/RegExp/prototype/Symbol.matchAll/name.js

@@ -1,15 +1,20 @@
 // Copyright (C) 2018 Jordan Harband. All rights reserved.
 // This code is governed by the BSD license found in the LICENSE file.
 /*---
+esid: pending
 description: RegExp.prototype[Symbol.matchAll] `name` property
 info: |
-    The value of the name property of this function is "[Symbol.matchAll]".
+  17 ECMAScript Standard Built-in Objects:
 
-    ES6 Section 17:
+    [...]
+
+    Every built-in function object, including constructors, that is not
+    identified as an anonymous function has a name property whose value
+    is a String.
 
     [...]
 
-    Unless otherwise specified, the name property of a built-in Function
+    Unless otherwise specified, the name property of a built-in function
     object, if it exists, has the attributes { [[Writable]]: false,
     [[Enumerable]]: false, [[Configurable]]: true }.
 includes: [propertyHelper.js]

test/built-ins/RegExp/prototype/Symbol.matchAll/prop-desc.js

@@ -1,10 +1,12 @@
 // Copyright (C) 2018 Jordan Harband. All rights reserved.
 // This code is governed by the BSD license found in the LICENSE file.
-
 /*---
+esid: pending
 description: RegExp.prototype[Symbol.matchAll] property descriptor
 info: |
-    ES6 Section 17
+  17 ECMAScript Standard Built-in Objects:
+
+    [...]
 
     Every other data property described in clauses 18 through 26 and in Annex
     B.2 has the attributes { [[Writable]]: true, [[Enumerable]]: false,
@@ -14,6 +16,7 @@ features: [Symbol.matchAll]
 ---*/
 
 assert.sameValue(typeof RegExp.prototype[Symbol.matchAll], 'function');
+
 verifyNotEnumerable(RegExp.prototype, Symbol.matchAll);
 verifyWritable(RegExp.prototype, Symbol.matchAll);
 verifyConfigurable(RegExp.prototype, Symbol.matchAll);

test/built-ins/RegExp/prototype/Symbol.matchAll/regexpcreate-this-throws.js

@@ -0,0 +1,29 @@
+// Copyright (C) 2018 Peter Wong. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: pending
+description: Re-throws errors while creating an internal RegExp
+info: |
+  RegExp.prototype [ @@matchAll ] ( string )
+    [...]
+    3. Return ? MatchAllIterator(R, string).
+
+  MatchAllIterator ( R, O )
+    [...]
+    2. If ? IsRegExp(R) is true, then
+      [...]
+    3. Else,
+      a. Let R be RegExpCreate(R, "g").
+features: [Symbol.matchAll]
+---*/
+
+var obj = {
+  toString() {
+    throw new Test262Error();
+  }
+};
+
+assert.throws(Test262Error, function() {
+  RegExp.prototype[Symbol.matchAll].call(obj, '');
+});
+

test/built-ins/RegExp/prototype/Symbol.matchAll/species-constructor-get-constructor-throws.js

@@ -0,0 +1,32 @@
+// Copyright (C) 2018 Peter Wong. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: pending
+description: |
+  Re-throws errors thrown while accessing RegExp's constructor property
+info: |
+  RegExp.prototype [ @@matchAll ] ( string )
+    [...]
+    3. Return ? MatchAllIterator(R, string).
+
+  MatchAllIterator ( R, O )
+    [...]
+    2. If ? IsRegExp(R) is true, then
+      a. Let C be ? SpeciesConstructor(R, RegExp).
+
+  SpeciesConstructor ( O, defaultConstructor )
+    [...]
+    2. Let C be ? Get(O, "constructor").
+features: [Symbol.matchAll]
+---*/
+
+var regexp = /./;
+Object.defineProperty(regexp, 'constructor', {
+  get(){
+    throw new Test262Error();
+  }
+});
+
+assert.throws(Test262Error, function() {
+  regexp[Symbol.matchAll]('');
+});

test/built-ins/RegExp/prototype/Symbol.matchAll/species-constructor-get-species-throws.js

@@ -0,0 +1,31 @@
+// Copyright (C) 2018 Peter Wong. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: pending
+description: Re-throws errors thrown while accessing of @@species property
+info: |
+  RegExp.prototype [ @@matchAll ] ( string )
+    [...]
+    3. Return ? MatchAllIterator(R, string).
+
+  MatchAllIterator ( R, O )
+    [...]
+    2. If ? IsRegExp(R) is true, then
+      a. Let C be ? SpeciesConstructor(R, RegExp).
+
+  SpeciesConstructor ( O, defaultConstructor )
+    [...]
+    2. Let C be ? Get(O, "constructor").
+features: [Symbol.matchAll, Symbol.species]
+---*/
+
+var regexp = /./;
+regexp.constructor = {
+  get [Symbol.species]() {
+    throw new Test262Error();
+  }
+};
+
+assert.throws(Test262Error, function() {
+  regexp[Symbol.matchAll]('');
+});