Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore non-string delimiters #16

Merged
merged 1 commit into from
Aug 8, 2014
Merged

ignore non-string delimiters #16

merged 1 commit into from
Aug 8, 2014

Conversation

bengl
Copy link
Contributor

@bengl bengl commented Aug 8, 2014

Prior to this, anything that wasn't undefined would be an acceptable delimiter. This doesn't really make sense, so this fixes that. In the event that a non-string delimiter is provided, it is simply ignored.

@nlf nlf added the bug label Aug 8, 2014
@nlf nlf added this to the 1.2.1 milestone Aug 8, 2014
@nlf nlf self-assigned this Aug 8, 2014
nlf added a commit that referenced this pull request Aug 8, 2014
@nlf
Merge pull request #16 from bengl/nonstringdelim
8bfec11 
ignore non-string delimiters
@nlf nlf merged commit 8bfec11 into ljharb:master Aug 8, 2014
@dougwilson
Copy link
Contributor

publish me :D

@nlf
Copy link
Collaborator

nlf commented Aug 9, 2014

v1.2.1 ;)

@dougwilson
Copy link
Contributor

👏 @nlf and company are awesome :)

@bengl
Copy link
Contributor Author

bengl commented Aug 9, 2014

rock on, guys! 🎸

mjackson added a commit to mjackson/qs that referenced this pull request Aug 25, 2014
@mjackson
Enable using a RegExp as delimiter
870577e 
This fixes a regression that was introduced in ljharb#16 which prevents
anything but a string from being used as a delimiter. But the whole
point of ljharb#12 was to allow users to specify a RegExp to use in
queryString.split(delimiter).
@mjackson mjackson mentioned this pull request Aug 25, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlf nlf

Labels
bug
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@bengl @dougwilson @nlf