From 1d043f09e6eb6ecf8456295efdbe4e7298f7c3c8 Mon Sep 17 00:00:00 2001 From: James Halliday Date: Mon, 6 Jun 2011 23:53:07 -0700 Subject: [PATCH] an amazing number of test descriptions were getting ignored --- test/equal.js | 175 +++++++++++++++++++++++++++----------------------- 1 file changed, 93 insertions(+), 82 deletions(-) diff --git a/test/equal.js b/test/equal.js index 509bc6d..4d732fa 100644 --- a/test/equal.js +++ b/test/equal.js @@ -2,19 +2,23 @@ var assert = require('assert'); var traverse = require('traverse'); exports.deepDates = function () { - assert.ok(traverse.deepEqual( - { d : new Date, x : [ 1, 2, 3 ] }, - { d : new Date, x : [ 1, 2, 3 ] }, + assert.ok( + traverse.deepEqual( + { d : new Date, x : [ 1, 2, 3 ] }, + { d : new Date, x : [ 1, 2, 3 ] } + ), 'dates should be equal' - )); + ); var d0 = new Date; setTimeout(function () { - assert.ok(!traverse.deepEqual( - { d : d0, x : [ 1, 2, 3 ], }, - { d : new Date, x : [ 1, 2, 3 ] }, + assert.ok( + !traverse.deepEqual( + { d : d0, x : [ 1, 2, 3 ], }, + { d : new Date, x : [ 1, 2, 3 ] } + ), 'microseconds should count in date equality' - )); + ); }, 5); }; @@ -46,82 +50,87 @@ exports.deepCircular = function () { }; exports.deepInstances = function () { - assert.ok(!traverse.deepEqual( - [ new Boolean(false) ], [ false ], + assert.ok( + !traverse.deepEqual([ new Boolean(false) ], [ false ]), 'boolean instances are not real booleans' - )); + ); - assert.ok(!traverse.deepEqual( - [ new String('x') ], [ 'x' ], + assert.ok( + !traverse.deepEqual([ new String('x') ], [ 'x' ]), 'string instances are not real strings' - )); + ); - assert.ok(!traverse.deepEqual( - [ new Number(4) ], [ 4 ], + assert.ok( + !traverse.deepEqual([ new Number(4) ], [ 4 ]), 'number instances are not real numbers' - )); + ); - assert.ok(traverse.deepEqual( - [ new RegExp('x') ], [ /x/ ], + assert.ok( + traverse.deepEqual([ new RegExp('x') ], [ /x/ ]), 'regexp instances are real regexps' - )); + ); - assert.ok(!traverse.deepEqual( - [ new RegExp(/./) ], [ /../ ], + assert.ok( + !traverse.deepEqual([ new RegExp(/./) ], [ /../ ]), 'these regexps aren\'t the same' - )); + ); - assert.ok(!traverse.deepEqual( - [ function (x) { return x * 2 } ], - [ function (x) { return x * 2 } ], + assert.ok( + !traverse.deepEqual( + [ function (x) { return x * 2 } ], + [ function (x) { return x * 2 } ] + ), 'functions with the same .toString() aren\'t necessarily the same' - )); + ); var f = function (x) { return x * 2 }; - assert.ok(traverse.deepEqual( - [ f ], [ f ], + assert.ok( + traverse.deepEqual([ f ], [ f ]), 'these functions are actually equal' - )); + ); }; exports.deepEqual = function () { - assert.ok(!traverse.deepEqual( - [ 1, 2, 3 ], - { 0 : 1, 1 : 2, 2 : 3 }, + assert.ok( + !traverse.deepEqual([ 1, 2, 3 ], { 0 : 1, 1 : 2, 2 : 3 }), 'arrays are not objects' - )); + ); }; exports.falsy = function () { - assert.ok(!traverse.deepEqual( - [ undefined ], - [ null ], + assert.ok( + !traverse.deepEqual([ undefined ], [ null ]), 'null is not undefined!' - )); + ); - assert.ok(!traverse.deepEqual( - [ null ], - [ undefined ], + assert.ok( + !traverse.deepEqual([ null ], [ undefined ]), 'undefined is not null!' - )); + ); - assert.ok(!traverse.deepEqual( - { a : 1, b : 2, c : [ 3, undefined, 5 ] }, - { a : 1, b : 2, c : [ 3, null, 5 ] }, + assert.ok( + !traverse.deepEqual( + { a : 1, b : 2, c : [ 3, undefined, 5 ] }, + { a : 1, b : 2, c : [ 3, null, 5 ] } + ), 'undefined is not null, however deeply!' - )); + ); - assert.ok(!traverse.deepEqual( - { a : 1, b : 2, c : [ 3, undefined, 5 ] }, - { a : 1, b : 2, c : [ 3, null, 5 ] }, + assert.ok( + !traverse.deepEqual( + { a : 1, b : 2, c : [ 3, undefined, 5 ] }, + { a : 1, b : 2, c : [ 3, null, 5 ] } + ), 'null is not undefined, however deeply!' - )); + ); - assert.ok(!traverse.deepEqual( - { a : 1, b : 2, c : [ 3, undefined, 5 ] }, - { a : 1, b : 2, c : [ 3, null, 5 ] }, + assert.ok( + !traverse.deepEqual( + { a : 1, b : 2, c : [ 3, undefined, 5 ] }, + { a : 1, b : 2, c : [ 3, null, 5 ] } + ), 'null is not undefined, however deeply!' - )); + ); }; exports.deletedArrayEqual = function () { @@ -133,43 +142,41 @@ exports.deletedArrayEqual = function () { ys[1] = 2; ys[3] = 4; - assert.ok(traverse.deepEqual( - xs, ys, + assert.ok( + traverse.deepEqual(xs, ys), 'arrays with deleted elements are only equal to' + ' arrays with similarly deleted elements' - )); + ); - assert.ok(!traverse.deepEqual( - xs, - [ 1, 2, undefined, 4 ], + assert.ok( + !traverse.deepEqual(xs, [ 1, 2, undefined, 4 ]), 'deleted array elements cannot be undefined' - )); + ); - assert.ok(!traverse.deepEqual( - xs, - [ 1, 2, null, 4 ], + assert.ok( + !traverse.deepEqual(xs, [ 1, 2, null, 4 ]), 'deleted array elements cannot be null' - )); + ); }; exports.deletedObjectEqual = function () { var obj = { a : 1, b : 2, c : 3 }; delete obj.c; - assert.ok(traverse.deepEqual( - obj, { a : 1, b : 2 }, + assert.ok( + traverse.deepEqual(obj, { a : 1, b : 2 }), 'deleted object elements should not show up' - )); + ); - assert.ok(!traverse.deepEqual( - obj, { a : 1, b : 2, c : undefined }, + assert.ok( + !traverse.deepEqual(obj, { a : 1, b : 2, c : undefined }), 'deleted object elements are not undefined' - )); + ); - assert.ok(!traverse.deepEqual( - obj, { a : 1, b : 2, c : null }, + assert.ok( + !traverse.deepEqual(obj, { a : 1, b : 2, c : null }), 'deleted object elements are not null' - )); + ); }; exports.emptyKeyEqual = function () { @@ -179,17 +186,21 @@ exports.emptyKeyEqual = function () { }; exports.deepArguments = function () { - assert.ok(!traverse.deepEqual( - [ 4, 5, 6 ], - (function () { return arguments })(4, 5, 6), + assert.ok( + !traverse.deepEqual( + [ 4, 5, 6 ], + (function () { return arguments })(4, 5, 6) + ), 'arguments are not arrays' - )); + ); - assert.ok(traverse.deepEqual( - (function () { return arguments })(4, 5, 6), - (function () { return arguments })(4, 5, 6), + assert.ok( + traverse.deepEqual( + (function () { return arguments })(4, 5, 6), + (function () { return arguments })(4, 5, 6) + ), 'arguments should equal' - )); + ); }; exports.deepUn = function () {