From 182fbc1504d7ed0a1de2daca4438abb5be84a717 Mon Sep 17 00:00:00 2001 From: Michal Paszowski Date: Fri, 26 Aug 2022 15:37:55 +0200 Subject: [PATCH 1/4] set zindex on popover --- .../react-components/src/components/Popover/Popover.module.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react-components/src/components/Popover/Popover.module.scss b/packages/react-components/src/components/Popover/Popover.module.scss index 17a428cbf..5378571b2 100644 --- a/packages/react-components/src/components/Popover/Popover.module.scss +++ b/packages/react-components/src/components/Popover/Popover.module.scss @@ -5,6 +5,7 @@ display: none; max-width: 336px; min-width: 168px; + z-index: 1000; &:focus { outline: none; From 590b04ca20e589278bade33f0bbbfb22eaba4220 Mon Sep 17 00:00:00 2001 From: Michal Paszowski Date: Fri, 2 Sep 2022 15:43:39 +0200 Subject: [PATCH 2/4] use zindex variable --- .../react-components/src/components/Popover/Popover.module.scss | 2 +- packages/react-components/src/utils/StackingContextLevel.scss | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/react-components/src/components/Popover/Popover.module.scss b/packages/react-components/src/components/Popover/Popover.module.scss index 5378571b2..5bda4b073 100644 --- a/packages/react-components/src/components/Popover/Popover.module.scss +++ b/packages/react-components/src/components/Popover/Popover.module.scss @@ -5,7 +5,7 @@ display: none; max-width: 336px; min-width: 168px; - z-index: 1000; + z-index: $stacking-context-level-popover; &:focus { outline: none; diff --git a/packages/react-components/src/utils/StackingContextLevel.scss b/packages/react-components/src/utils/StackingContextLevel.scss index 19839718c..72a898f95 100644 --- a/packages/react-components/src/utils/StackingContextLevel.scss +++ b/packages/react-components/src/utils/StackingContextLevel.scss @@ -3,3 +3,4 @@ */ $stacking-context-level-dropdown: 10000; +$stacking-context-level-popover: 11000; From 3054c6a5a2348c533352077fd7b589b65c035a6e Mon Sep 17 00:00:00 2001 From: Michal Paszowski Date: Fri, 2 Sep 2022 15:45:55 +0200 Subject: [PATCH 3/4] follow agent app convention --- packages/react-components/src/utils/StackingContextLevel.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-components/src/utils/StackingContextLevel.scss b/packages/react-components/src/utils/StackingContextLevel.scss index 72a898f95..36b825023 100644 --- a/packages/react-components/src/utils/StackingContextLevel.scss +++ b/packages/react-components/src/utils/StackingContextLevel.scss @@ -2,5 +2,5 @@ * Definition of z-index values to be used across application. */ -$stacking-context-level-dropdown: 10000; -$stacking-context-level-popover: 11000; +$stacking-context-level-dropdown: 2000; +$stacking-context-level-popover: 1000; From 1dead9220ec0f2ed83f702820b7ffe8a741a5ed2 Mon Sep 17 00:00:00 2001 From: Michal Paszowski Date: Thu, 8 Sep 2022 19:54:34 +0200 Subject: [PATCH 4/4] import variable --- .../react-components/src/components/Popover/Popover.module.scss | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/react-components/src/components/Popover/Popover.module.scss b/packages/react-components/src/components/Popover/Popover.module.scss index 5bda4b073..c16247441 100644 --- a/packages/react-components/src/components/Popover/Popover.module.scss +++ b/packages/react-components/src/components/Popover/Popover.module.scss @@ -1,3 +1,5 @@ +@import '../../utils/StackingContextLevel'; + .popover { background-color: var(--surface-basic-default); border-radius: 4px;