Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Picker] Improvements (default selected option, search input disabling, z-index , and border-box) #337

Closed
marcinsawicki opened this issue Jul 1, 2022 · 1 comment · Fixed by #336
Closed

[Picker] Improvements (default selected option, search input disabling, z-index , and border-box) #337

marcinsawicki opened this issue Jul 1, 2022 · 1 comment · Fixed by #336
Assignees
@marcinsawicki
Labels
bug Something isn't working feature New feature or request

Comments

@marcinsawicki
Copy link
Contributor

Description

Add missing functionality:

  • possibility to provide default selected option
  • possibility to disable search input

UI improvements:

  • add z-index prop for the list to display on top of other items
  • add border-box to prevent inheriting it from the parent, which allows to display the component as designed
@marcinsawicki marcinsawicki added the feature New feature or request label Jul 1, 2022
@marcinsawicki marcinsawicki self-assigned this Jul 1, 2022
@marcinsawicki marcinsawicki mentioned this issue Jul 1, 2022
Merged
@marcinsawicki marcinsawicki added the bug Something isn't working label Jul 1, 2022
@marcinsawicki marcinsawicki moved this to In Progress in LiveChat Design System Jul 1, 2022
@marcinsawicki marcinsawicki linked a pull request Jul 1, 2022 that will close this issue
Improvements for Picker component #336
Merged
@marcinsawicki marcinsawicki added this to the v1.0.0 milestone Jul 1, 2022
@sgraczyk sgraczyk changed the title Picker improvements - add missing functionality + add UI fixes [Picker] Improvements (default selected option, search input disabling, z-index , and border-box) Jul 1, 2022
@marcinsawicki marcinsawicki moved this from In Progress to Done in LiveChat Design System Jul 8, 2022
@sgraczyk
Copy link

Released in v1.0.0-alpha.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcinsawicki marcinsawicki

Labels
bug Something isn't working feature New feature or request
Projects
LiveChat Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improvements for Picker component livechat/design-system
2 participants
@sgraczyk @marcinsawicki