forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparation for 0.16.2 release candidate #523
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub-Pull: bitcoin#12859 Rebased-From: a5bca13
GitHub-Pull: bitcoin#13131 Rebased-From: ddebde7
GitHub-Pull: bitcoin#13451 Rebased-From: 86edf4a
Github-Pull: bitcoin#13507 Rebased-From: 3f72d04
GitHub-Pull: bitcoin#13544 Rebased-From: 2fca656
9fd3e00 depends: Update Qt download url (fanquake) f7401c8 Fix parameter count check for importpubkey. (Kristaps Kaupe) cbd2f70 expose CBlockIndex::nTx in getblock(header) (Gregory Sanders) ce8aa54 Add Windows shutdown handler (Chun Kuan Lee) 18b0c69 Bugfix: Include <memory> for std::unique_ptr (Luke Dashjr) Pull request description: Backports: * bitcoin#12859 Bugfix: Include <memory> for std::unique_ptr * bitcoin#13131 Add Windows shutdown handler * bitcoin#13451 rpc: expose CBlockIndex::nTx in getblock(header) * bitcoin#13507 RPC: Fix parameter count check for importpubkey * bitcoin#13544 depends: Update Qt download url to the 0.16 branch. Tree-SHA512: eeaec52d001d5c81e67dda3a2d3fee7a9445e569366e597b18e81d802c1b7f89e545afd53d094740c37c1714050304979398b9860144454d3a5cb5abc9e9eaca
I thought we had removed this a long time ago, TBH, its really confusing feedback to users that we display whether a tx was broadcast to immediate neighbor nodes, given that has little indication of whether the tx propagated very far. Github-Pull: bitcoin#13622 Rebased-From: beef7ec
Added handling for the case where headers are announced over more than one message. refs bitcoin#12453 Github-Pull: bitcoin#13192 Rebased-From: 12d1b77
Github-Pull: bitcoin#13304 Rebased-From: fa865ef
Github-Pull: bitcoin#12793 Rebased-From: 342fb80
Log messages should terminate with a '\n', or the following log will be written to the same line without a timestamp. Fix a couple of cases where the message is not terminated with a \n. Github-Pull: bitcoin#12887 Rebased-From: 5b10ab0
Github-Pull: bitcoin#12837 Rebased-From: 05c03d1
Larger values seem to trigger a bug on macos+libevent (resulting in the rpc server stopping). Github-Pull: bitcoin#12905 Rebased-From: 662d19f
also test that 64 bit integers are properly handled Github-Pull: bitcoin#13061 Rebased-From: 3ee4be1
Github-Pull: bitcoin#13545 Rebased-From: c6fd0df
Github-Pull: bitcoin#13545 Rebased-From: 962d8ee
Github-Pull: bitcoin#13437 Rebased-From: faa18ca
Github-Pull: bitcoin#13452 Rebased-From: ed82f17
Github-Pull: bitcoin#13452 Rebased-From: d280617
#ifdef is not correct since defination is defined to 0 or 1. Should change to #if Github-Pull: bitcoin#12573 Rebased-From: 1830784
Github-Pull: bitcoin#12743 Rebased-From: 45dd135
Github-Pull: bitcoin#12432 Rebased-From: f506c0a
Currently, error messages (such as InitError) are displayed as-is, which means Qt does auto detection on the format. This means that it's possible to inject HTML from the command line though e.g. specifying a wallet name with HTML in it. This isn't a direct security risk because fetching content from internet is disabled (and as far as I know we never report strings received from the network this way). However, it can be confusing. So explicitly force the format as text. Github-Pull: bitcoin#12617 Rebased-From: 6fbc098
Github-Pull: bitcoin#13300 Rebased-From: fa9da85
d9c5630 qa: Initialize lockstack to prevent null pointer deref (MarcoFalke) 21dd512 gui: Show messages as text not html (Wladimir J. van der Laan) f78e7f6 [qt] send: Clear All also resets coin control options (Sjors Provoost) 657dfc5 Fix csBestBlock/cvBlockChange waiting in rpc/mining (Pieter Wuille) 88d1a64 Consensus: Fix bug when compiler do not support __builtin_clz* (532479301) b72c0bd [qa] Add a test for merkle proof malleation (Suhas Daftuar) 6b9dc8c have verifytxoutproof check the number of txns in proof structure (Gregory Sanders) ed82e71 wallet: Erase wtxOrderd wtx pointer on removeprunedfunds (MarcoFalke) e15e3a9 Remove boost dependency (boost/assign/std/vector.hpp) (practicalswift) 1062199 Fix incorrect tests (practicalswift) 170b309 Make tests pass after 2020 (Bernhard M. Wiedemann) cfc6f74 [rpcwallet] Clamp walletpassphrase value at 100M seconds (Suhas Daftuar) bf1f150 rpc: fix type mistmatch in listreceivedbyaddress (joemphilips) 2291774 [trivial] Add newlines to end of log messages. (John Newbery) cf6feb7 qt: Avoid resetting on resetguisettigs=0 (MarcoFalke) cbdabef qa: Fix wallet_listreceivedby race (MarcoFalke) 79c4fff [tests] Fixed intermittent failure in p2p_sendheaders.py. (lmanners) c04a4a5 Remove useless mapRequest tracking that just effects Qt display. (Matt Corallo) Pull request description: Some gui/doc/rpc/qa backports Tree-SHA512: f1e918d2ca6016fc7c5d5adf5d537553a1769731e2dcac788edf02c7354387861ec5bcd0cbf3c833c1485d500c55a73a2799a8b39ed14477524ac46b4ff2332d
Prior to this change, it would mark only the first layer of child transactions abandoned, due to always following the input hashTx rather than the current now tx. Github-Pull: bitcoin#13652 Rebased-From: 89e70f9 Tree-SHA512: 403da0cc400a807e5a30038bd505881a68208c3f9e96ad5a7755e763666982bc3c19564ac13a5757612c8b6efc331fb2ad0edbaf7e830993b84bc64624423e54
Tree-SHA512: f146372b303213af48ed57fc33ef1cc0aa07a205c53bb5bba291f58dfcae56673841e726a54fd57e6faedfddb011f6e8b40230635abf5701deac1b2ef4b03e59
Tree-SHA512: cb2a7cd91447b6e4ad13055e97b542c6984309e28cd33898f3c4bbe92141c6cb65cc472821b34e63f94aa675553d8d68709c431255ccc17e0fc0c54c0c3836bc
0296b9c 0.16.2: Bump manpages (MarcoFalke) Pull request description: Tree-SHA512: 6fffb8ca0e3f2fbbb7561bf9e8710b1ece6475cc76d56120b790b0fa6261cb7a06f65816ab49a37e1ef5b99883d3e9649ac7f8dcabcfb716de03ca85a86cd320
coblee
approved these changes
Jul 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
losh11
approved these changes
Jul 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Thanks guys! |
thrasher-
pushed a commit
to thrasher-/litecoin
that referenced
this pull request
Dec 6, 2019
b19c000 Merge litecoin-project#607: Use size_t shifts when computing a size_t 4d01bc2 Merge litecoin-project#606: travis: Remove unused sudo:false e6d01e9 Use size_t shifts when computing a size_t 7667532 travis: Remove unused sudo:false ee99f12 Merge litecoin-project#599: Switch x86_64 asm to use "i" instead of "n" for immediate values. d58bc93 Switch x86_64 asm to use "i" instead of "n" for immediate values. 05362ee Merge litecoin-project#597: Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build 8348386 Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build aa15154 Merge litecoin-project#568: Fix integer overflow in ecmult_multi_var when n is large 2277af5 Fix integer overflow in ecmult_multi_var when n is large 85d0e1b Merge litecoin-project#591: Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing. 1419637 Merge litecoin-project#580: Add trivial ecmult_multi algorithm which does not require a scratch space a697d82 Add trivial ecmult_multi to the benchmark tool bade617 Add trivial ecmult_multi algorithm. It is selected when no scratch space is given and just multiplies and adds the points. 5545e13 Merge litecoin-project#584: configure: Use CFLAGS_FOR_BUILD when checking native compiler 20c5869 Merge litecoin-project#516: improvements to random seed in src/tests.c b76e45d Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing. 870a977 Merge litecoin-project#562: Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse be40c4d Fixup for C90 mixed declarations. c71dd2c Merge litecoin-project#509: Fix algorithm selection in bench_ecmult 6492bf8 Merge litecoin-project#518: Summarize build options after running configure 0e9ada1 Merge litecoin-project#567: Correct order of libs returned on pkg-config --libs --static libsecp2… e96901a Merge litecoin-project#587: Make randomization of a non-signing context a noop 58df8d0 Merge litecoin-project#511: Portability fix for the configure scripts generated 2ebdad7 Merge litecoin-project#552: Make constants static: 1c131af Merge litecoin-project#551: secp256k1_fe_sqrt: Verify that the arguments don't alias. ba698f8 Merge litecoin-project#539: Assorted minor corrections 949e85b Merge litecoin-project#550: Optimize secp256k1_fe_normalize_weak calls. a34bcaa Actually pass CFLAGS_FOR_BUILD and LDFLAGS_FOR_BUILD to linker 2d5f4ce configure: Use CFLAGS_FOR_BUILD when checking native compiler b408c6a Merge litecoin-project#579: Use __GNUC_PREREQ for detecting __builtin_expect 6198375 Make randomization of a non-signing context a noop c663397 Use __GNUC_PREREQ for detecting __builtin_expect e34ceb3 Merge litecoin-project#557: Eliminate scratch memory used when generating contexts b3bf5f9 ecmult_impl: expand comment to explain how effective affine interacts with everything efa783f Store z-ratios in the 'x' coord they'll recover ffd3b34 add `secp256k1_ge_set_all_gej_var` test which deals with many infinite points 84740ac ecmult_impl: save one fe_inv_var 4704527 ecmult_impl: eliminate scratch memory used when generating context 7f7a2ed ecmult_gen_impl: eliminate scratch memory used when generating context 314a61d Merge litecoin-project#553: add static context object which has no capabilities 89a20a8 Correct order of libs returned on pkg-config --libs --static libsecp256k1 call. 1086fda Merge litecoin-project#354: [ECDH API change] Support custom hash function d3cb1f9 Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse 40fde61 prevent attempts to modify `secp256k1_context_no_precomp` ed7c084 add static context object which has no capabilities 496c5b4 Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static const int CURVE_B; bf8b86c secp256k1_fe_sqrt: Verify that the arguments don't alias. 9bd89c8 Optimize secp256k1_fe_normalize_weak calls. Move secp256k1_fe_normalize_weak calls out of ECMULT_TABLE_GET_GE and ECMULT_TABLE_GET_GE_STORAGE and into secp256k1_ge_globalz_set_table_gej instead. 52ab96f clean dependendies in field_*_impl.h deff5ed Correct math typos in field_*.h 4efb3f8 Add check that restrict pointers don't alias with all parameters. 1e6f1f5 Merge litecoin-project#529: fix tests.c in the count == 0 case c8fbc3c [ECDH API change] Allow pass arbitrary data to hash function b00be65 [ECDH API change] Support custom hash function 95e99f1 fix tests.c in the count == 0 case 452d8e4 Merge litecoin-project#523: scratch: add stack frame support 6fe5043 scratch: add stack frame support 9bc2e26 Merge litecoin-project#522: parameterize ecmult_const over input size 7c1b91b parameterize ecmult_const over input size dbc3ddd Merge litecoin-project#513: Increase sparsity of pippenger fixed window naf representation 3965027 Summarize build options in configure script 0f05173 Fix algorithm selection in bench_ecmult fb9271d Merge litecoin-project#510: add a couple missing `const`s to ecmult_pippenger_wnaf cd5f602 Merge litecoin-project#515: Fix typo 09146ae Merge litecoin-project#512: secp256k1_ec_privkey_negate - fix documentation ec0a7b3 Don't touch leading zeros in wnaf_fixed. 9e36d1b Fix bug in wnaf_fixed where the wnaf array is not completely zeroed when given a 0 scalar. 96f68a0 Don't invert scalar in wnaf_fixed when it is even because a caller might intentionally give a scalar with many leading zeros. 8b3841c fix bug in fread() failure check cddef0c tests: add warning message when /dev/urandom fails 9b7c47a Fix typo 6dbb007 Increase sparsity of pippenger fixed window naf representation 1646ace secp256k1_ec_privkey_negate - fix documentation 270f6c8 Portability fix for the configure scripts generated 9b3ff03 add a couple missing `const`s to ecmult_pippenger_wnaf cd329db Merge litecoin-project#460: [build] Update ax_jni_include_dir.m4 macro 7f9c1a1 Merge litecoin-project#498: tests: Avoid calling fclose(...) with an invalid argument f99aa8d Merge litecoin-project#499: tests: Make sure we get the requested number of bytes from /dev/urandom b549d3d Merge litecoin-project#472: [build] Set --enable-jni to no by default instead of auto. d333521 Merge litecoin-project#494: Support OpenSSL versions >= 1.1 for ENABLE_OPENSSL_TESTS 2ef8ea5 Merge litecoin-project#495: Add bench_ecmult to .gitignore 82a96e4 tests: Make sure we get the requested number of bytes from /dev/urandom 5aae5b5 Avoid calling fclose(...) with an invalid argument cb32940 Add bench_ecmult to .gitignore 31abd3a Support OpenSSL versions >= 1.1 for ENABLE_OPENSSL_TESTS c95f6f1 Merge litecoin-project#487: fix tests typo, s/changed/unchanged fb46c83 Merge litecoin-project#463: Reduce usage of hardcoded size constants 02f5001 Merge litecoin-project#490: Disambiguate bench functions and types 1f46d60 Disambiguate bench functions and types f54c6c5 Merge litecoin-project#480: Enable benchmark building by default c77fc08 Merge litecoin-project#486: Add pippenger_wnaf for multi-multiplication d2f9c6b Use more precise pippenger bucket windows 4c950bb Save some additions per window in _pippenger_wnaf a58f543 Add flags for choosing algorithm in ecmult_multi benchmark 36b22c9 Use scratch space dependent batching in ecmult_multi 355a38f Add pippenger_wnaf ecmult_multi bc65aa7 Add bench_ecmult dba5471 Add ecmult_multi tests 8c1c831 Generalize Strauss to support multiple points 548de42 add resizeable scratch space API 0e96cdc fix typo, s/changed/unchanged c7680e5 Reduce usage of hardcoded size constants 6ad5cdb Merge litecoin-project#479: Get rid of reserved _t in type names 7a78f60 Print whether we're building benchmarks 4afec9f Build benchmarks by default d1dc9df Get rid of reserved _t in type names 57752d2 [build] Set --enable-jni to no by default instead of auto. e7daa9b [build] Tweak JNI macro to warn instead of error for JNI not found. 5b22977 [build] Update ax_jni_include_dir.m4 macro to deal with recent versions of macOS git-subtree-dir: src/secp256k1 git-subtree-split: b19c000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synced with upstream 0.16.2 (about to be released)
Contains important updates, including bug fixes, code improvements and updated dependencies.
A full list of changes can be seen at https://github.com/litecoin-project/litecoin/blob/d949bf74d1baf5f927e0e34eb8f6bba7f923b70d/doc/release-notes-litecoin.md