Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🦺[Tech Debt] Remove any BR-Specific or Unused Code #163

Closed
11 tasks
kcw-grunt opened this issue Nov 29, 2022 · 0 comments
Closed
11 tasks

🦺[Tech Debt] Remove any BR-Specific or Unused Code #163

kcw-grunt opened this issue Nov 29, 2022 · 0 comments
Assignees
@Iferencak
Labels
🦺 tech debt Actions that help maintain the repo and application

Comments

@kcw-grunt
Copy link
Contributor

kcw-grunt commented Nov 29, 2022 •
edited
Loading

Goal

Describe the work to be done

Remove any latent cruft . In this case the fork planned on having a remote server with the KV Store.

Loafwallet and Litewallet never used that code so it should be taken out.

Definition of Done

  • Remove private class KVStoreAdaptor: dependencies and callers
  • Remove BRReplicatedKVStore
  • Maybe remove ContainerViewController
  • ForgotViewModel
  • Remove loafwallet/src/Views/PinPadCells/PinPadCells.swift
  • Maybe Remove NonScrollingCollectionView
  • Maybe Remove PartnerAPIManager
  • Maybe Remove SupportLFViewModel
  • Maybe Remove Async.swift
  • Maybe Remove File.swift
  • Maybe SearchHeaderView
@kcw-grunt kcw-grunt added the 🦺 tech debt Actions that help maintain the repo and application label Nov 29, 2022
@kcw-grunt kcw-grunt self-assigned this Nov 29, 2022
@kcw-grunt kcw-grunt changed the title 🦺[Tech Debt] Remove any BRRemoteKVStore HTTPS code 🦺[Tech Debt] Remove any BR-Specific Code Nov 29, 2022
@kcw-grunt kcw-grunt assigned Iferencak and unassigned kcw-grunt Nov 29, 2022
@kcw-grunt kcw-grunt changed the title 🦺[Tech Debt] Remove any BR-Specific Code 🦺[Tech Debt] Remove any BR-Specific or Unused Code Nov 29, 2022
@kcw-grunt kcw-grunt mentioned this issue Dec 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Iferencak Iferencak

Labels
🦺 tech debt Actions that help maintain the repo and application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kcw-grunt @Iferencak