Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Extra Columns Available for Custom Table #86

Closed
ljilekor opened this issue Sep 30, 2023 · 4 comments · Fixed by #88
Closed

ENH: Extra Columns Available for Custom Table #86

ljilekor opened this issue Sep 30, 2023 · 4 comments · Fixed by #88
Assignees
Labels
bug Something isn't working

Comments

@ljilekor
Copy link

ljilekor commented Sep 30, 2023

Some columns are not available in the 'Custom' table.
finvizfinance provides columns 0 to 70

But finviz has a few more columns:
https://finviz.com/screener.ashx?v=152&c=73,%2075,%2076,%2077,%2078,%2079,%2080,%2081,%2082,%2083,%2084,%2085,%2086,%2087,%2088

non_implemented_col_ids = [73, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88]

EXTRA_COLUMNS = {
 73 : 'Book Value per Share',
 75 : 'Dividend',
 76 : 'Employees',
 ...
 86 : 'Open'
 87 : 'High',
 88 : 'Low',
}

For the sake of cleanness, completeness and because this is an easy fix,
I was going to fiddle with the base code.
But after seeing that the Sept 28 issue got fixed very quickly (big up @lit26 !), it may be better to implement this properly in the original code?

Any chance to see this implemented soon?

@ljilekor ljilekor changed the title ENH: ENH: Extra Columns Available for Custom Table Sep 30, 2023
@lit26 lit26 self-assigned this Oct 2, 2023
@lit26 lit26 added the bug Something isn't working label Oct 2, 2023
@lit26 lit26 closed this as completed in #88 Oct 2, 2023
@lit26
Copy link
Owner

lit26 commented Oct 3, 2023

Should be fixed in the latest. Please check

@ljilekor
Copy link
Author

ljilekor commented Oct 4, 2023

Thanks @lit26 !! Great stuff.
I saw you added the missing columns to screener.custom.py

But after doing a 'pip install finvizfinance', I get only the old 70 columns... (v 0,14.6)
from finvizfinance.screener.custom import COLUMNS

Am I doing something wrong?

@lit26
Copy link
Owner

lit26 commented Oct 4, 2023

Use the pre-release version. The latest is v0.14.7rc2.

@ljilekor
Copy link
Author

ljilekor commented Oct 6, 2023

Great
pip install finvizfinance==0.14.7rc2
did the trick!

Thx @lit26 for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants