Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion - timeout for scrapoing #21

Closed
camilo-rojas opened this issue Apr 16, 2021 · 2 comments
Closed

Suggestion - timeout for scrapoing #21

camilo-rojas opened this issue Apr 16, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@camilo-rojas
Copy link

Hi thanks for the time here, im thinking of using your library, one suggestion:
In the Util.py - webscrap
website = requests.get(url, headers=headers)
You may want to setup a timeout, as this helps handle different use cases.
better if its handled from the Object constructor as an optional parameter.

Thanks again.

@lit26 lit26 added the enhancement New feature or request label Apr 16, 2021
@lit26
Copy link
Owner

lit26 commented Apr 16, 2021

Thanks for your advice. I will implement it.

@lit26
Copy link
Owner

lit26 commented Apr 19, 2021

The package is updated. Please check the latest version.

@lit26 lit26 closed this as completed Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants