Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change color of temporary evaluation result? #389

Closed
mars0i opened this issue Mar 16, 2022 · 6 comments
Closed

Change color of temporary evaluation result? #389

mars0i opened this issue Mar 16, 2022 · 6 comments

Comments

@mars0i
Copy link
Contributor

mars0i commented Mar 16, 2022

When evaluating code with <Leader>ei, <Leader>et, etc., the result is temporarily displayed to the right of the line after "=> ". The displayed result is in the the Comment color from the user's color scheme.

Is there a way to change this color to make it different from the Comment color? Since comments are static parts of a source file, and the evaluation result is temporary, for me it would be nicer if the color of the evaluation result conveyed that it was temporary and made it stand out. (I know I can change the color of the temporary result display by changing my Comment color, but I want the result display to be in a different color from my comments.)

Or if there's no way to change it, maybe I could just modify my own copy of the .vim viles to make the color different? I haven't yet figured out which file this is in. Thanks.

@liquidz
Copy link
Owner

liquidz commented Mar 16, 2022

@mars0i Thanks for your reporting!
Currently, the highlight setting for popuped results are fixed.

You can change it at below:

let virtual_text_opt['highlight'] = 'Comment'

But it may be good to add option for modifing the highlight setting.

@mars0i
Copy link
Contributor Author

mars0i commented Mar 16, 2022

Thanks @liquidz! I've changed it now.

I like the idea of adding an option for changing the highlight setting for the evaluation results. I suppose that some people might want to be able to configure other colors, such as the stdout popup. (I don't need to change the stdout popup colors.)

@liquidz
Copy link
Owner

liquidz commented Mar 18, 2022

@mars0i I added g:iced#eval#popup_highlight option to change the highlight setting to dev branch.
https://vim-iced-nightly.netlify.app/vim-iced.html#g%3Aiced%23eval%23popup_highlight

Could you try dev branch?

@mars0i
Copy link
Contributor Author

mars0i commented Mar 19, 2022

Yes, works perfectly for me. Thank you!

@liquidz
Copy link
Owner

liquidz commented Mar 19, 2022

@mars0i Just released v3.8.3 #392

@mars0i
Copy link
Contributor Author

mars0i commented Mar 19, 2022

Excellent--thanks. I just updated.

@liquidz liquidz closed this as completed Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants