Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDR4 support broken on Linux 5.16.3 #416

Closed
jonasmalacofilho opened this issue Feb 2, 2022 · 2 comments
Closed

DDR4 support broken on Linux 5.16.3 #416

jonasmalacofilho opened this issue Feb 2, 2022 · 2 comments
Labels
external Problem that is external to liquidctl i2c/smbus I²C or SMBus device linux Linux users are particularly affected

Comments

@jonasmalacofilho
Copy link
Member

On Linux 5.16.4, trying to read the SPD EEPROM from /sys/bus/i2c/drivers/ee1004/*/eeprom or from suitable /sys/bus/i2c/devices/*/*/eeprom files fails with EPROTO.

This breaks the Ddr4Temperature and VengeanceRgb drivers' probing code in smbus.load_eeprom().

The problem appears to be new to Linux 5.16.4 or Linux 5.16.3; on Linux 5.16.2 there is no such issue. Even on 5.16.4, it also doesn't affect the decode-dimms command from i2c-tools; but that command only reads the first page (first 256 bytes) of the SPD EEPROM.

Additional information about the system:

  • Affected device: DDR4 memory modules
  • Operating system: Arch Linux with linux 5.16.4.arch1-1
  • Liquidctl version: git HEAD
@jonasmalacofilho jonasmalacofilho added the bug Apparent bug in liquidctl label Feb 2, 2022
@jonasmalacofilho
Copy link
Member Author

Most likely related to torvalds/linux@effa453 ("i2c: i801: Don't silently correct invalid transfer size").12

Footnotes

  1. Patchwork ↩

  2. The commit was backported to the 5.16 stable series and released as part of 5.16.3. ↩

@jonasmalacofilho jonasmalacofilho changed the title DDR4 support broken on Linux 5.16.4 DDR4 support broken on Linux 5.16.3 Feb 3, 2022
@jonasmalacofilho jonasmalacofilho added linux Linux users are particularly affected external Problem that is external to liquidctl labels Feb 3, 2022
@jonasmalacofilho
Copy link
Member Author

jonasmalacofilho commented Feb 3, 2022 •
edited
Loading

Patch for the ee1004 kernel driver: https://lore.kernel.org/lkml/[email protected]/

Status:

jonasmalacofilho added a commit that referenced this issue Feb 4, 2022
@jonasmalacofilho
smbus: remove most bare Exception sinks
016d430 
One instance is left due to #416, but only until the corresponding
problem is fixed upstream.  Even then, the exception is no longer
silently consumed.

Related: #416
jonasmalacofilho added a commit that referenced this issue Feb 6, 2022
@jonasmalacofilho
smbus: eeprom: work around #416 by reading in 128 chunks
b21200c 
Related: #416
jonasmalacofilho added a commit that referenced this issue Feb 6, 2022
@jonasmalacofilho
smbus: eeprom: bubble up unexpected exceptions
0166fa1 
Related: #416
@jonasmalacofilho jonasmalacofilho removed the bug Apparent bug in liquidctl label Feb 10, 2022
@jonasmalacofilho jonasmalacofilho mentioned this issue Mar 3, 2022
Closed
@jonasmalacofilho jonasmalacofilho added the i2c/smbus I²C or SMBus device label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external Problem that is external to liquidctl i2c/smbus I²C or SMBus device linux Linux users are particularly affected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonasmalacofilho