Some minor changes to make LSP use easier #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xml
parse data as part of thereshape_info(info = )
parameter, since this is already pre-parsed by the lsp.reshape_info
The
reshape_info()
interface is just about perfect for the LSP as it is. You can see how it's used in this function in my fork of{languageserver}
in these lines. However, the RStudio addin and emacs interfaces have more bespoke wrappers. Since the rest of the logic is lsp-implementation-specific, it seemed most natural to just exportreshape_info
, but I would understand if you'd prefer to keep a more consistent with the other tool interfaces.