Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimise cutline handling by only using the cutline if required #258

Merged
merged 5 commits into from
Dec 14, 2022

Conversation

blacha
Copy link
Member

@blacha blacha commented Dec 12, 2022

No description provided.

@blacha blacha marked this pull request as ready for review December 12, 2022 23:09
@blacha blacha requested a review from a team as a code owner December 12, 2022 23:09
return None

# Not asked to optimize the cutline
if not optimize:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left this disabled for now, as it needs more testing and just by ignoring the cutline for most tiles should significantly speed up the process

@blacha
Copy link
Member Author

blacha commented Dec 12, 2022

This logic can be removed once OSGeo/gdal#6905 is released.


# osgeo is embbed in the Docker image
from osgeo import gdal # pylint: disable=import-error
from osgeo import Geometry, Layer, ogr # pylint: disable=import-error
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could import everything from osgeo in the same line

@kodiakhq kodiakhq bot merged commit 5000a65 into master Dec 14, 2022
@kodiakhq kodiakhq bot deleted the feat/optimise-cutline branch December 14, 2022 22:59
@github-actions github-actions bot mentioned this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants