feat(lambda-tiler): Add file number limitation to import api. #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wentao-Kuang
commented
May 17, 2022
| @@ -217,11 +217,9 @@ export class CogStacJob implements CogJob { | |||
| bounds: metadata.targetBounds, | |||
| oneCogCovering: ctx.oneCogCovering, | |||
| }, | |||
| processingId: ctx.override?.processingId, | |||
There was a problem hiding this comment.
This fix a problem for passing processingId to job.json. Otherwise, I need to set it as job.json.processingId = ctx.override?.processingId;
blacha
reviewed
May 17, 2022
| @@ -44,6 +44,7 @@ export async function Import(req: LambdaHttpRequest): Promise<LambdaHttpResponse | |||
| if (role == null) return new LambdaHttpResponse(403, 'Unable to Access the s3 bucket'); | |||
| const files = await findImagery(path); | |||
| if (files.length === 0) return new LambdaHttpResponse(404, 'Imagery Not Found'); | |||
| if (files.length >= 500) return new LambdaHttpResponse(400, `Too many files to process. Files: ${files.length}`); | |||
There was a problem hiding this comment.
this limit would be way too low, maybe 5_000 ?
There was a problem hiding this comment.
Sure. Updated.
blacha
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.