feat(config): add configuration parser and bundler #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
blacha
commented
May 17, 2022
blacha
commented
- feat(config-cli): import configuration cli from linz/basemaps-config
- fix: include bin/
- feat: load screenshot config from file
- feat: add name to log lines
|
This pull request introduces 1 alert when merging 4f56419 into f962fe2 - view on LGTM.com new alerts:
|
blacha
force-pushed
the
feat/basemaps-config-cli
branch
from
4f56419 to
e4a20aa
Compare
|
This pull request introduces 1 alert when merging e4a20aa into 4694e29 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging d4b3f62 into 4694e29 - view on LGTM.com new alerts:
|
blacha
force-pushed
the
feat/basemaps-config-cli
branch
from
e28ec4d to
ac9a570
Compare
| const id = Config.prefix(ConfigPrefix.Imagery, guessIdFromUri(uri)); | ||
|
|
||
| const fileList = await fsa.toArray(fsa.list(uri)); | ||
| const tiffFiles = fileList.filter((f) => f.endsWith('.tiff')); |
There was a problem hiding this comment.
Do we consider imagery end with .tif ?
There was a problem hiding this comment.
these our COGs so we decide what they end with
blacha
changed the title
Wentao-Kuang
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.