-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split FHIR 4.0.1 conformance artifacts into separate module and exclude by default #3447
Comments
Signed-off-by: Lee Surprenant <[email protected]>
Signed-off-by: Lee Surprenant <[email protected]>
Also added core-r4b and this new hl7-terminology modules to the list of modules in fhir-parent and also added them as dependencies to fhir-validation. In the future, I'd like to take these out of the main build and build+release them separately (similar to fhir-examples). Signed-off-by: Lee Surprenant <[email protected]>
I thought that we needed the hl7.terminology package so that we could expand the R4B ValueSets, but it turns out the R4B downloads page has its own "expansions.json" download that contains all of the necessary ValueSets. Now only fhir-core-r4b will be packaged on the server by default...if someone needs the other 3000+ resources from hl7.terminology they can still add that to the userlib. Signed-off-by: Lee Surprenant <[email protected]>
I thought that we needed the hl7.terminology package so that we could expand the R4B ValueSets, but it turns out the R4B downloads page has its own "expansions.json" download that contains all of the necessary ValueSets. Now only fhir-core-r4b will be packaged on the server by default...if someone needs the other 3000+ resources from hl7.terminology they can still add that to the userlib. Signed-off-by: Lee Surprenant <[email protected]>
While investigating this one, I found some rather significant changes in the way v2 and v3 codesystems are represented in FHIR. Firstly, the v3 codesystems now use a property-based hierarchy instead of a nested-code hierachy. I opened #3448 for that one, but I think we can do without it if we package the pre-expanded valuesets that are downloadable from the r4b downloads page. Second, at least the v2 codesystems (and maybe others) now indicate that they are caseSensitive. Previously they were missing this element and, in these cases, our implementation assumed them to be not case-sensitive. |
Signed-off-by: Lee Surprenant <[email protected]>
Also added core-r4b and this new hl7-terminology modules to the list of modules in fhir-parent and also added them as dependencies to fhir-validation. In the future, I'd like to take these out of the main build and build+release them separately (similar to fhir-examples). Signed-off-by: Lee Surprenant <[email protected]>
I thought that we needed the hl7.terminology package so that we could expand the R4B ValueSets, but it turns out the R4B downloads page has its own "expansions.json" download that contains all of the necessary ValueSets in their expanded form. Now only fhir-core-r4b will be packaged on the server by default...if someone needs the other 3000+ resources from hl7.terminology they can still add that to the userlib. Signed-off-by: Lee Surprenant <[email protected]>
Signed-off-by: Lee Surprenant <[email protected]>
Also added core-r4b and this new hl7-terminology modules to the list of modules in fhir-parent and also added them as dependencies to fhir-validation. In the future, I'd like to take these out of the main build and build+release them separately (similar to fhir-examples). Signed-off-by: Lee Surprenant <[email protected]>
I thought that we needed the hl7.terminology package so that we could expand the R4B ValueSets, but it turns out the R4B downloads page has its own "expansions.json" download that contains all of the necessary ValueSets in their expanded form. Now only fhir-core-r4b will be packaged on the server by default...if someone needs the other 3000+ resources from hl7.terminology they can still add that to the userlib. Signed-off-by: Lee Surprenant <[email protected]>
After current PR is approved and merged to r4b branch:
|
Signed-off-by: Lee Surprenant <[email protected]>
Signed-off-by: Lee Surprenant <[email protected]>
Also added core-r4b and this new hl7-terminology modules to the list of modules in fhir-parent and also added them as dependencies to fhir-validation. In the future, I'd like to take these out of the main build and build+release them separately (similar to fhir-examples). Signed-off-by: Lee Surprenant <[email protected]>
I thought that we needed the hl7.terminology package so that we could expand the R4B ValueSets, but it turns out the R4B downloads page has its own "expansions.json" download that contains all of the necessary ValueSets in their expanded form. Now only fhir-core-r4b will be packaged on the server by default...if someone needs the other 3000+ resources from hl7.terminology they can still add that to the userlib. Signed-off-by: Lee Surprenant <[email protected]>
Signed-off-by: Lee Surprenant <[email protected]>
Signed-off-by: Lee Surprenant <[email protected]>
Also added core-r4b and this new hl7-terminology modules to the list of modules in fhir-parent and also added them as dependencies to fhir-validation. In the future, I'd like to take these out of the main build and build+release them separately (similar to fhir-examples). Signed-off-by: Lee Surprenant <[email protected]>
I thought that we needed the hl7.terminology package so that we could expand the R4B ValueSets, but it turns out the R4B downloads page has its own "expansions.json" download that contains all of the necessary ValueSets in their expanded form. Now only fhir-core-r4b will be packaged on the server by default...if someone needs the other 3000+ resources from hl7.terminology they can still add that to the userlib. Signed-off-by: Lee Surprenant <[email protected]>
Signed-off-by: Lee Surprenant <[email protected]>
Signed-off-by: Lee Surprenant <[email protected]>
Also added core-r4b and this new hl7-terminology modules to the list of modules in fhir-parent and also added them as dependencies to fhir-validation. In the future, I'd like to take these out of the main build and build+release them separately (similar to fhir-examples). Signed-off-by: Lee Surprenant <[email protected]>
I thought that we needed the hl7.terminology package so that we could expand the R4B ValueSets, but it turns out the R4B downloads page has its own "expansions.json" download that contains all of the necessary ValueSets in their expanded form. Now only fhir-core-r4b will be packaged on the server by default...if someone needs the other 3000+ resources from hl7.terminology they can still add that to the userlib. Signed-off-by: Lee Surprenant <[email protected]>
Verified based on acceptance criteria. Closing issue |
Is your feature request related to a problem? Please describe.
After rebasing onto the latest from main, I noticed our build logs filling with messages like the following:
Because each SearchParameter is now in the registry twice (once for 4.0.1 and once for 4.3.0), we get a conflict on every one.
Describe the solution you'd like
Move the 4.0.1 conformance artifacts from the registry to a separate module and do not include that in the server by default.
If that proves problematic, consider moving just the SearchParameters out.
Describe alternatives you've considered
Add some kind of feature to just always use the newer search parameter definition by default.
Acceptance Criteria
WHEN the server starts
THEN there should be no warnings in the logs during startup (or at least they should be minimal)
Additional context
I thought that we used 4.0.1 structure definitions while validating profiles but, based on local testing, that doesn't actually seem to be the case. I think because we use the snapshot and not the differential, having just the profile (without the StructureDefinition on which its based) is sufficient for runtime validation.
The only time we should need the actual 4.0.1 StructureDefinitions is if we're using a utility like our ProfileBuilder or ExtensionBuilder to actually build new profiles.
We should probably also package up the latest HL7 terminologies into a separate jar. These used to be distributed with the FHIR specification but now they have their own separate packaging. separate issue?
The text was updated successfully, but these errors were encountered: