Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 增加应用内通知动画 #592

Merged
merged 1 commit into from
Aug 22, 2024
Merged

chore: 增加应用内通知动画 #592

merged 1 commit into from
Aug 22, 2024

Conversation

Whale107
Copy link
Contributor

@Whale107 Whale107 commented Aug 5, 2024

增加应用内通知动画

Log:

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Whale107

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Aug 5, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkwidget
03ddbf6 
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#592
@deepin-ci-robot deepin-ci-robot mentioned this pull request Aug 5, 2024
Merged
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 5, 2024

Doc Check bot
🟡 some documents missing!

File Line Symbol
include/widgets/dmessagemanager.h 29 DMessageManager * DMessageManager::instance
include/widgets/dmessagemanager.h 32 void DMessageManager::sendMessage
include/widgets/dmessagemanager.h 33 void Dtk::Widget::DMessageManager::sendMessage
include/widgets/dmessagemanager.h 34 bool DMessageManager::setContentMargens
src/widgets/private/dmessagemanager_p.h 23 QPropertyAnimation* Dtk::Widget::DMessageManagerPrivate::m_aniGeometry
src/widgets/private/dmessagemanager_p.h 24 QPropertyAnimation* Dtk::Widget::DMessageManagerPrivate::m_aniOpacity
src/widgets/private/dmessagemanager_p.h 25 QParallelAnimationGroup* Dtk::Widget::DMessageManagerPrivate::m_aniGroup
src/widgets/private/dmessagemanager_p.h 26 QLabel* Dtk::Widget::DMessageManagerPrivate::m_label
src/widgets/private/dmessagemanager_p.h 21 Dtk::Widget::DMessageManagerPrivate::DMessageManagerPrivate
src/widgets/private/dmessagemanager_p.h 28 Dtk::Widget::DMessageManagerPrivate::D_DECLARE_PUBLIC
src/widgets/private/dmessagemanager_p.h 18 Dtk::Widget::DMessageManagerPrivate

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Aug 5, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkwidget
c348f68 
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#592
@Whale107
chore: 增加应用内通知动画
bf31303 
增加应用内通知动画

Log:
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Aug 5, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkwidget
3a9eb60 
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#592
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 在DFloatingMessage类的init()方法中，使用了connect函数来连接动画组的finished信号，但没有提供槽函数。这可能导致槽函数未连接，无法处理动画完成后的逻辑。
  • 在DMessageManagerPrivate类的构造函数中，m_aniGroup的初始化应该包括QPropertyAnimation::DeleteWhenStopped特性。
  • DMessageManagerPrivate类的setContentMargins方法中，应该检查content是否为nullptr，以避免潜在的空指针解引用。
  • DMessageManagerPrivate类的eventFilter方法中，对于event类型为QEvent::ChildRemoved的情况，应该添加对watched是否为nullptr的检查，以避免潜在的空指针解引用。
  • DMessageManagerPrivate类的drawPrimitive方法中，使用Qt::NoPen代替了QPen，但没有提供QPen的初始化参数，这可能会导致绘制的矩形没有边框。
  • DMessageManagerPrivate类的drawPrimitive方法中，对于pe为DStyle::PrimitiveRect的情况，使用了frameRadius变量，但没有提供该变量的初始化。
  • DMessageManagerPrivate类的drawPrimitive方法中，对于pe为DStyle::PrimitiveRoundedRect的情况，使用了frameRadius变量，但没有提供该变量的初始化。
  • DMessageManagerPrivate类的drawPrimitive方法中，对于pe为DStyle::PrimitivePath的情况，使用了frameRadius变量，但没有提供该变量的初始化。
  • DMessageManagerPrivate类的drawPrimitive方法中，对于pe为DStyle::PrimitiveImage的情况，使用了frameRadius变量，但没有提供该变量的初始化。
  • DMessageManagerPrivate类的drawPrimitive方法中，对于pe为DStyle::PrimitiveText的情况，使用了frameRadius变量，但没有提供该变量的初始化。
  • DMessageManagerPrivate类的drawPrimitive方法中，对于pe为DStyle::PrimitiveCustom的情况，使用了frameRadius变量，但没有提供该变量的初始化。

是否建议立即修改:
是

@Whale107 Whale107 merged commit ed80342 into linuxdeepin:dev/animation Aug 22, 2024
20 of 21 checks passed
Whale107 added a commit to Whale107/dtkwidget that referenced this pull request Sep 23, 2024
@Whale107
chore: 增加应用内通知动画 (linuxdeepin#592)
fb921f9 
增加应用内通知动画

Log:
deepin-bot bot pushed a commit that referenced this pull request Sep 23, 2024
@Whale107 @deepin-bot
chore: 增加应用内通知动画 (#592)
6cfb9ab 
增加应用内通知动画

Log:
FeiWang1119 pushed a commit to linuxdeepin/dtk6widget that referenced this pull request Sep 25, 2024
@deepin-ci-robot @FeiWang1119
sync: from linuxdeepin/dtkwidget
ea66362 
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kegechen kegechen Awaiting requested review from kegechen

@FeiWang1119 FeiWang1119 Awaiting requested review from FeiWang1119

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Whale107 @deepin-ci-robot