feat: auto load qt translations #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally, Qt applications need to explicitly load translations by themselves, including Qt translations. Here we take the initiative to help applications that have loaded dtk (including plugins) load translations. Issue: linuxdeepin/developer-center#6417
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kegechen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Dec 15, 2023
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#212
|
Doc Check bot |
kegechen
commented
Dec 15, 2023
|
|
||
| // load qt/qtbase translation for qt app which load dtk ? | ||
| QTimer::singleShot(0, [](){ | ||
| DGuiApplicationHelper::loadTranslator(); |
There was a problem hiding this comment.
让应用自己加载不就行了，否则在非DDE、非KDE环境上应用程序怎么办？这本来就是一个没有保障的事情。
zccrs
requested changes
Dec 18, 2023
|
|
||
| // load qt/qtbase translation for qt app which load dtk ? | ||
| QTimer::singleShot(0, [](){ | ||
| DGuiApplicationHelper::loadTranslator(); |
There was a problem hiding this comment.
让应用自己加载不就行了，否则在非DDE、非KDE环境上应用程序怎么办？这本来就是一个没有保障的事情。
|
输入法插件改 |
kegechen
pushed a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Dec 20, 2023
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, Qt applications need to explicitly load translations by themselves, including Qt translations. Here we take the initiative to help applications that have loaded dtk (including plugins) load translations.
Issue: linuxdeepin/developer-center#6417