Fix usb keyboard at init #1362
Merged
Fix usb keyboard at init #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlaurion
force-pushed
the
fix_usb_keyboard_at_init
branch
from
35c34f4 to
c2d5c6e
Compare
|
Thanks @tlaurion, the changes to functions and ash_functions look good to me. You might want to edit OP to say that enable_usb was moved, not that we're sourcing functions from init. (I agree with moving enable_usb, BTW, I think that's a bit cleaner.) |
tlaurion
force-pushed
the
fix_usb_keyboard_at_init
branch
from
6a4693a to
7c72c1a
Compare
… keyboard can be enabled from init Reminder: insmod is a bash script and will fail on legacy-flash boards (which should not enable USB_KEYBOARD anyway)
…unctions where they are called from
tlaurion
force-pushed
the
fix_usb_keyboard_at_init
branch
from
7c72c1a to
8dbe85d
Compare
|
@JonathonHall-Purism removed talos II commits from #1313 on which this was tested functional and modified OP. |
This was referenced Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TPM2 board inclusion made bash required, and we missed early usb keyboard enablement+testing after moving some required init functions, but not all required ones, from functions to ash_functions, causing a regression on x230 usb-keyb and talos, requiring early usb keyboard support.
enable_usb function is moved /etc/ash_functions to be called from init, which otherwise don't find needed function, since init only sources the minimal ash_functions before switching to boot policy (gui-init or any other specified in board config)
That code is required to do measurements in PCR5 prior of actually loading the kernel modules drivers.
/sbin/insmod is actually a wrapper script calling
busybox insmodafter having measured modules to be loaded.This prevents unsealing secrets which requires runtime related PCRs to be consistent to be unsealed.
As a reminder, Heads doesn't enable USB stack unless needed.
On host like the Talos II without ps2, USB support is required to interact with the machine early at boot.
And to have usb HID (USB keyboard support) the USB controllers drivers needs to be loaded. All of which is provvided by enable_usb function.
@krystian-hebel this PR addresses #1313 (comment)
I will test talos rom on top of this, and then rebase my commit on master instead of #1313 to merge this alone as fix on master so that you can rebase on master only including current relevant commit 35c34f4