Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odbc_driver_18 #302

Open
devisbal opened this issue Sep 20, 2024 · 6 comments
Open

odbc_driver_18 #302

devisbal opened this issue Sep 20, 2024 · 6 comments

Comments

@devisbal
Copy link

Will it be possible to add the odbc_driver_18
Actually this is the only one available:
accept_microsoft_odbc_driver_17_for_sql_server_eula

@spetrosi
Copy link
Collaborator

Hello @devisbal, this variable serves as a confirmation that user accepts EULA, same as other mssql_accept_* variables. This confirmation is required when you install mssql-server package. If these variables are not set to true, role fail, otherwise it proceeds and installs mssql-server package.

Are you saying that now mssql-server package requires odbc_driver version 18? If yes, this is not an issue because the role installs the driver version that is required by the mssql-server package.

The issue in naming, though, exists. I guess the best is to rename accept_microsoft_odbc_driver_17_for_sql_server_eula to remove version number, like accept_microsoft_odbc_driver_for_sql_server_eula to remove maintenance burden. With a note that accept_microsoft_odbc_driver_17_for_sql_server_eula will still be supported as deprecated for some time.

@spetrosi
Copy link
Collaborator

I confirm that there is a bug in the role, on RHEL 9 it installs mssql-tools-17 instead of mssql-tools18-18. I'll work with Microsoft to fix this. I don't think RHEL 9 requires mssql-tools-17 at all if version 18 is available.

@spetrosi
Copy link
Collaborator

Some updates on this, the role works fine with mssql-tools-17 that it installs. mssql-tools-18 has some additional functionality for editing databases, and because some of the new functionality is not backward-compatible, Microsoft added it in a separate package.
Right now the role works fine.
I will add a variable to install a newer mssql-tools-18 for those users who need it.

@spetrosi
Copy link
Collaborator

Resolved by #307

@spetrosi
Copy link
Collaborator

And also by #318

@spetrosi
Copy link
Collaborator

spetrosi commented Nov 25, 2024

@devisbal do these two PRs #307 and #318 fix your troubles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants