From e903bc1b20943d6bc959ab1bb0313bb1a333d162 Mon Sep 17 00:00:00 2001
From: Rich Megginson <rmeggins@redhat.com>
Date: Tue, 10 Oct 2023 13:29:45 -0600
Subject: [PATCH] feat: support for ostree systems

Feature: Allow running and testing the role with ostree managed nodes.

Reason: We have users who want to use the role to manage ostree
systems.

Result: Users can use the role to manage ostree managed nodes.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
---
 .ostree/README.md                     |   3 +
 .ostree/get_ostree_data.sh            | 113 ++++++++++++++++++++++++++
 .ostree/packages-runtime.txt          |   1 +
 .ostree/packages-testing-CentOS-8.txt |   1 +
 .ostree/packages-testing-CentOS-9.txt |   1 +
 .ostree/packages-testing-Fedora.txt   |   1 +
 .ostree/packages-testing-RedHat-8.txt |   1 +
 .ostree/packages-testing-RedHat-9.txt |   1 +
 .ostree/packages-testing.txt          |   1 +
 README.md                             |  68 ++++++++++++++++
 meta/collection-requirements.yml      |   3 +
 tasks/firewalld.yml                   |  18 ++++
 tests/tests_reload_on_reset.yml       |  18 ++++
 tests/tests_startup_conflicts.yml     |  18 ++++
 14 files changed, 248 insertions(+)
 create mode 100644 .ostree/README.md
 create mode 100755 .ostree/get_ostree_data.sh
 create mode 100644 .ostree/packages-runtime.txt
 create mode 100644 .ostree/packages-testing-CentOS-8.txt
 create mode 100644 .ostree/packages-testing-CentOS-9.txt
 create mode 100644 .ostree/packages-testing-Fedora.txt
 create mode 100644 .ostree/packages-testing-RedHat-8.txt
 create mode 100644 .ostree/packages-testing-RedHat-9.txt
 create mode 100644 .ostree/packages-testing.txt
 create mode 100644 meta/collection-requirements.yml

diff --git a/.ostree/README.md b/.ostree/README.md
new file mode 100644
index 00000000..f5e6931b
--- /dev/null
+++ b/.ostree/README.md
@@ -0,0 +1,3 @@
+*NOTE*: The `*.txt` files are used by `get_ostree_data.sh` to create the lists
+of packages, and to find other system roles used by this role.  DO NOT use them
+directly.
diff --git a/.ostree/get_ostree_data.sh b/.ostree/get_ostree_data.sh
new file mode 100755
index 00000000..cbc502fb
--- /dev/null
+++ b/.ostree/get_ostree_data.sh
@@ -0,0 +1,113 @@
+#!/bin/bash
+
+set -euo pipefail
+
+role_collection_dir="${ROLE_COLLECTION_DIR:-fedora/linux_system_roles}"
+ostree_dir="${OSTREE_DIR:-"$(dirname "$(realpath "$0")")"}"
+
+if [ -z "${4:-}" ] || [ "${1:-}" = help ] || [ x"${1:-}" = x-h ]; then
+    cat <<EOF
+Usage: $0 packages [runtime|testing] DISTRO-MAJOR[.MINOR] [json|yaml|raw|toml]
+The script will use the packages and roles files in $ostree_dir to
+construct the list of packages needed to build the ostree image.  The script
+will output the list of packages in the given format
+- json is a JSON list like ["pkg1","pkg2",....,"pkgN"]
+- yaml is the YAML list format
+- raw is the list of packages, one per line
+- toml is a list of [[packages]] elements as in https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/9/html-single/composing_installing_and_managing_rhel_for_edge_images/index#creating-an-image-builder-blueprint-for-a-rhel-for-edge-image-using-the-command-line-interface_composing-a-rhel-for-edge-image-using-image-builder-command-line
+The DISTRO-MAJOR.MINOR is the same format used by Ansible for distribution e.g. CentOS-8, RedHat-8.9, etc.
+EOF
+    exit 1
+fi
+category="$1"
+pkgtype="$2"
+distro_ver="$3"
+format="$4"
+pkgtypes=("$pkgtype")
+if [ "$pkgtype" = testing ]; then
+    pkgtypes+=(runtime)
+fi
+
+get_rolepath() {
+    local ostree_dir role rolesdir
+    ostree_dir="$1"
+    role="$2"
+    rolesdir="$(dirname "$(dirname "$ostree_dir")")/$role/.ostree"
+    if [ -d "$rolesdir" ]; then
+        echo "$rolesdir"
+        return 0
+    fi
+    if [ -n "${ANSIBLE_COLLECTIONS_PATHS:-}" ]; then
+        for pth in ${ANSIBLE_COLLECTIONS_PATHS//:/ }; do
+            rolesdir="$pth/ansible_collections/$role_collection_dir/roles/$role/.ostree"
+            if [ -d "$rolesdir" ]; then
+                echo "$rolesdir"
+                return 0
+            fi
+        done
+    fi
+    return 1
+}
+
+get_packages() {
+    local ostree_dir pkgtype pkgfile rolefile
+    ostree_dir="$1"
+    for pkgtype in "${pkgtypes[@]}"; do
+        for suff in "" "-$distro" "-${distro}-${major_ver}" "-${distro}-${ver}"; do
+            pkgfile="$ostree_dir/packages-${pkgtype}${suff}.txt"
+            if [ -f "$pkgfile" ]; then
+                cat "$pkgfile"
+            fi
+        done
+        rolefile="$ostree_dir/roles-${pkgtype}.txt"
+        if [ -f "$rolefile" ]; then
+            local roles role rolepath
+            roles="$(cat "$rolefile")"
+            for role in $roles; do
+                rolepath="$(get_rolepath "$ostree_dir" "$role")"
+                get_packages "$rolepath"
+            done
+        fi
+    done | sort -u
+}
+
+format_packages_json() {
+    local comma pkgs pkg
+    comma=""
+    pkgs="["
+    while read -r pkg; do
+        pkgs="${pkgs}${comma}\"${pkg}\""
+        comma=,
+    done
+    pkgs="${pkgs}]"
+    echo "$pkgs"
+}
+
+format_packages_raw() {
+    cat
+}
+
+format_packages_yaml() {
+    while read -r pkg; do
+        echo "- $pkg"
+    done
+}
+
+format_packages_toml() {
+    while read -r pkg; do
+        echo "[[packages]]"
+        echo "name = \"$pkg\""
+        echo "version = \"*\""
+    done
+}
+
+distro="${distro_ver%%-*}"
+ver="${distro_ver##*-}"
+if [[ "$ver" =~ ^([0-9]*) ]]; then
+    major_ver="${BASH_REMATCH[1]}"
+else
+    echo ERROR: cannot parse major version number from version "$ver"
+    exit 1
+fi
+
+"get_$category" "$ostree_dir" | "format_${category}_$format"
diff --git a/.ostree/packages-runtime.txt b/.ostree/packages-runtime.txt
new file mode 100644
index 00000000..5c96fcac
--- /dev/null
+++ b/.ostree/packages-runtime.txt
@@ -0,0 +1 @@
+firewalld
diff --git a/.ostree/packages-testing-CentOS-8.txt b/.ostree/packages-testing-CentOS-8.txt
new file mode 100644
index 00000000..5247d591
--- /dev/null
+++ b/.ostree/packages-testing-CentOS-8.txt
@@ -0,0 +1 @@
+podman
diff --git a/.ostree/packages-testing-CentOS-9.txt b/.ostree/packages-testing-CentOS-9.txt
new file mode 100644
index 00000000..5247d591
--- /dev/null
+++ b/.ostree/packages-testing-CentOS-9.txt
@@ -0,0 +1 @@
+podman
diff --git a/.ostree/packages-testing-Fedora.txt b/.ostree/packages-testing-Fedora.txt
new file mode 100644
index 00000000..5247d591
--- /dev/null
+++ b/.ostree/packages-testing-Fedora.txt
@@ -0,0 +1 @@
+podman
diff --git a/.ostree/packages-testing-RedHat-8.txt b/.ostree/packages-testing-RedHat-8.txt
new file mode 100644
index 00000000..5247d591
--- /dev/null
+++ b/.ostree/packages-testing-RedHat-8.txt
@@ -0,0 +1 @@
+podman
diff --git a/.ostree/packages-testing-RedHat-9.txt b/.ostree/packages-testing-RedHat-9.txt
new file mode 100644
index 00000000..5247d591
--- /dev/null
+++ b/.ostree/packages-testing-RedHat-9.txt
@@ -0,0 +1 @@
+podman
diff --git a/.ostree/packages-testing.txt b/.ostree/packages-testing.txt
new file mode 100644
index 00000000..6bc869b3
--- /dev/null
+++ b/.ostree/packages-testing.txt
@@ -0,0 +1 @@
+nftables
diff --git a/README.md b/README.md
index 4c9192f1..1892ce5f 100644
--- a/README.md
+++ b/README.md
@@ -926,6 +926,74 @@ The block with several services, ports, etc. will be applied at once. If there i
 
 ```
 
+## rpm-ostree
+
+The role supports running on [rpm-ostree](https://coreos.github.io/rpm-ostree/)
+systems. The primary difference is that the `/usr` filesystem is read-only, and
+the role cannot install packages. Instead, it will just verify that the
+necessary packages and any other `/usr` files are pre-installed. The role uses
+the `rhel_facts` module to gather facts from ostree systems, and uses the
+`rhel_rpm_ostree` package module implementation.
+
+### Building
+
+To build an ostree image for a particular operating system distribution and
+version, use the script `.ostree/get_ostree_data.sh` to get the list of
+packages. If the role uses other system roles, then the script will include the
+packages for the other roles in the list it outputs.  The list of packages will
+be sorted in alphanumeric order.
+
+Usage:
+
+```bash
+.ostree/get_ostree_data.sh packages runtime DISTRO-VERSION FORMAT
+```
+
+`DISTRO-VERSION` is in the format that Ansible uses for `ansible_distribution`
+and `ansible_distribution_version` - for example, `Fedora-38`, `CentOS-8`,
+`RedHat-9.4`
+
+`FORMAT` is one of `toml`, `json`, `yaml`, `raw`
+
+* `toml` - each package in a TOML `[[packages]]` element
+
+```toml
+[[packages]]
+name = "package-a"
+version = "*"
+[[packages]]
+name = "package-b"
+version = "*"
+...
+```
+
+* `yaml` - a YAML list of packages
+
+```yaml
+- package-a
+- package-b
+...
+```
+
+* `json` - a JSON list of packages
+
+```json
+["package-a","package-b",...]
+```
+
+* `raw` - a plain text list of packages, one per line
+
+```bash
+package-a
+package-b
+...
+```
+
+What format you choose depends on which image builder you are using.  For
+example, if you are using something based on
+[osbuild-composer](https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/9/html-single/composing_installing_and_managing_rhel_for_edge_images/index#creating-an-image-builder-blueprint-for-a-rhel-for-edge-image-using-the-command-line-interface_composing-a-rhel-for-edge-image-using-image-builder-command-line),
+you will probably want to use the `toml` output format.
+
 ## Authors
 
 Thomas Woerner
diff --git a/meta/collection-requirements.yml b/meta/collection-requirements.yml
new file mode 100644
index 00000000..a0cd255e
--- /dev/null
+++ b/meta/collection-requirements.yml
@@ -0,0 +1,3 @@
+---
+collections:
+  - name: ansible.posix
diff --git a/tasks/firewalld.yml b/tasks/firewalld.yml
index c0a9f636..bff988d9 100644
--- a/tasks/firewalld.yml
+++ b/tasks/firewalld.yml
@@ -5,6 +5,24 @@
   when: __firewall_required_facts |
     difference(ansible_facts.keys() | list) | length > 0
 
+- name: Ensure correct package manager for ostree systems
+  vars:
+    ostree_pkg_mgr: ansible.posix.rhel_rpm_ostree
+  when: ansible_facts.pkg_mgr | d("") != ostree_pkg_mgr
+  block:
+    - name: Check if system is ostree
+      ansible.posix.rhel_facts:
+      register: __rhel_facts
+
+    - name: Set package manager to use for ostree
+      set_fact:
+        ansible_facts: "{{ ansible_facts |
+          combine(new_facts, recursive=True) }}"
+      vars:
+        new_facts:
+          pkg_mgr: "{{ ostree_pkg_mgr }}"
+      when: __rhel_facts['ansible_facts'].get('pkg_mgr') == ostree_pkg_mgr
+
 - name: Install firewalld
   package:
     name: "{{ __firewall_packages_base }}"
diff --git a/tests/tests_reload_on_reset.yml b/tests/tests_reload_on_reset.yml
index a23a3c51..89a50710 100644
--- a/tests/tests_reload_on_reset.yml
+++ b/tests/tests_reload_on_reset.yml
@@ -9,6 +9,24 @@
         - ansible_distribution in ['RedHat', 'CentOS']
         - ansible_distribution_major_version | int < 8
   tasks:
+    - name: Ensure correct package manager for ostree systems
+      vars:
+        ostree_pkg_mgr: ansible.posix.rhel_rpm_ostree
+      when: ansible_facts.pkg_mgr | d("") != ostree_pkg_mgr
+      block:
+        - name: Check if system is ostree
+          ansible.posix.rhel_facts:
+          register: __rhel_facts
+
+        - name: Set package manager to use for ostree
+          set_fact:
+            ansible_facts: "{{ ansible_facts |
+              combine(new_facts, recursive=True) }}"
+          vars:
+            new_facts:
+              pkg_mgr: "{{ ostree_pkg_mgr }}"
+          when: __rhel_facts['ansible_facts'].get('pkg_mgr') == ostree_pkg_mgr
+
     - name: Install podman
       package:
         name: podman
diff --git a/tests/tests_startup_conflicts.yml b/tests/tests_startup_conflicts.yml
index eac699e6..c232817c 100644
--- a/tests/tests_startup_conflicts.yml
+++ b/tests/tests_startup_conflicts.yml
@@ -16,6 +16,24 @@
       include_role:
         name: linux-system-roles.firewall
 
+    - name: Ensure correct package manager for ostree systems
+      vars:
+        ostree_pkg_mgr: ansible.posix.rhel_rpm_ostree
+      when: ansible_facts.pkg_mgr | d("") != ostree_pkg_mgr
+      block:
+        - name: Check if system is ostree
+          ansible.posix.rhel_facts:
+          register: __rhel_facts
+
+        - name: Set package manager to use for ostree
+          set_fact:
+            ansible_facts: "{{ ansible_facts |
+              combine(new_facts, recursive=True) }}"
+          vars:
+            new_facts:
+              pkg_mgr: "{{ ostree_pkg_mgr }}"
+          when: __rhel_facts['ansible_facts'].get('pkg_mgr') == ostree_pkg_mgr
+
     - name: Install conflicting service
       package:
         name: nftables