Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation install failure with nvme-cli 2.10 #2448

Closed
jpalus opened this issue Aug 2, 2024 · 4 comments · Fixed by #2449 or linux-nvme/libnvme#874
Closed

Documentation install failure with nvme-cli 2.10 #2448

jpalus opened this issue Aug 2, 2024 · 4 comments · Fixed by #2449 or linux-nvme/libnvme#874

Comments

@jpalus
Copy link

jpalus commented Aug 2, 2024

nvme-cli 2.10 ships new asciidoc document nvme-ocp-unsupported-reqs-log-pages.txt, hower filename and document title do not match:

nvme-ocp-unsupported-reqs-log(1)
================================

This causes issues as install expects to find manpage matching file name while xmlto outputs manpage matching title resulting in installation failure:

...
Installing Documentation/nvme-ocp-telemetry-string-log-page.1 to /home/users/builder/tmp/nvme-cli-2.10-aarch64-root-builder/usr/share/man/man1

ERROR: File 'Documentation/nvme-ocp-unsupported-reqs-log-pages.1' could not be found
FAILED: meson-internal__install 
...
@igaw
Copy link
Collaborator

igaw commented Aug 2, 2024

I run into the same issue. The fix is 4c1e89f ("docs: rename ocp-unsupported-req-log file")

I suppose the doc CI build should also do a install step to find these kind of errors.

@igaw
Copy link
Collaborator

igaw commented Aug 2, 2024

The question is, do you need a bug fix release? Or are you okay with the fix in the tree?

@jpalus
Copy link
Author

jpalus commented Aug 2, 2024

Personally I can manage without dedicated release although possibly there might more entities affected.

@igaw
Copy link
Collaborator

igaw commented Aug 2, 2024

Alright, I'll wait a bit longer before deciding if we do bugfix release. Maybe there is another bug lurking around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants