Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lack of emoji support on Windows #247

Closed
luftywiranda13 opened this issue Sep 4, 2017 · 10 comments
Closed

Fix lack of emoji support on Windows #247

luftywiranda13 opened this issue Sep 4, 2017 · 10 comments

Comments

@luftywiranda13
Copy link
Collaborator

luftywiranda13 commented Sep 4, 2017

Emoji isn't supported on windows cmd

like this line
https://github.com/okonet/lint-staged/blob/d99eb3815cbcb7f76d0adf693fe4017c8e31cf7c/src/runScript.js#L50

and this line
https://github.com/okonet/lint-staged/blob/d99eb3815cbcb7f76d0adf693fe4017c8e31cf7c/src/runScript.js#L54

So I'm thinking about using log-symbols to replace those emojis. What do you guys think? any opinions?

@sudo-suhas
Copy link
Collaborator

I like it. But wouldn't this be better - https://github.com/sindresorhus/figures?

@okonet
Copy link
Collaborator

okonet commented Sep 4, 2017

That's great! I was thinking of replacing them with symbols.

@okonet
Copy link
Collaborator

okonet commented Sep 4, 2017

I like the https://github.com/sindresorhus/log-symbols more since it's more focused for the job.

What about Listr? Does it have required fallbacks?

@luftywiranda13
Copy link
Collaborator Author

I prefer log-symbols, because it's not bloated and hmmm has colors 😆

@okonet okonet added the Windows label Sep 4, 2017
@luftywiranda13
Copy link
Collaborator Author

What about Listr? Does it have required fallbacks?

yeah, Listr uses log-symbols

@luftywiranda13
Copy link
Collaborator Author

luftywiranda13 commented Sep 4, 2017

I think it's even better to utilize https://github.com/SamVerschueren/listr#promises, ain't it?

@okonet
Copy link
Collaborator

okonet commented Sep 4, 2017

@luftywiranda13 in what context? Not sure how it's related to symbols...

@sudo-suhas
Copy link
Collaborator

We are utilizing it already. runScript returns a promise.

@luftywiranda13
Copy link
Collaborator Author

ah yeah, how could I miss that 😆

so... is it worth to try if I make a PR to integrate log-symbols?

@sudo-suhas
Copy link
Collaborator

+1 from me!

@okonet okonet changed the title consider using log-symbols? Fix emoji support on Windows using log-symbols? Sep 5, 2017
@okonet okonet changed the title Fix emoji support on Windows using log-symbols? Fix lack of emoji support on Windows Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants