-
-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lack of emoji support on Windows #247
Comments
I like it. But wouldn't this be better - https://github.com/sindresorhus/figures? |
That's great! I was thinking of replacing them with symbols. |
I like the https://github.com/sindresorhus/log-symbols more since it's more focused for the job. What about Listr? Does it have required fallbacks? |
I prefer log-symbols, because it's not bloated and hmmm has colors 😆 |
yeah, Listr uses log-symbols |
I think it's even better to utilize https://github.com/SamVerschueren/listr#promises, ain't it? |
@luftywiranda13 in what context? Not sure how it's related to symbols... |
We are utilizing it already. |
ah yeah, how could I miss that 😆 so... is it worth to try if I make a PR to integrate |
+1 from me! |
log-symbols
?log-symbols
?
log-symbols
?
Emoji isn't supported on windows cmd
like this line
https://github.com/okonet/lint-staged/blob/d99eb3815cbcb7f76d0adf693fe4017c8e31cf7c/src/runScript.js#L50
and this line
https://github.com/okonet/lint-staged/blob/d99eb3815cbcb7f76d0adf693fe4017c8e31cf7c/src/runScript.js#L54
So I'm thinking about using log-symbols to replace those emojis. What do you guys think? any opinions?
The text was updated successfully, but these errors were encountered: