(Get Request) Fix issue with _httpRequest parameters #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `url` parameter used in _httpRequest call and update tests. Update codeception bin path and remove logs_path so default is used
|
Thx m8 |
|
Well, this issue is not fully fixed right now. The tests still breaking on windows now because of: #57 I'll going to fix that in yii2-curl 1.1.2 |
|
v1.1.1 is released now: https://github.com/linslin/Yii2-Curl/releases/tag/1.1.1 |
|
Thanks @linslin. About the windows issue, I see it's because of the bin path. Had to modify it to run the tests on my Mac. Might need to make a PR to phiremock to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
urlparameter used in _httpRequest call and update tests.Update codeception bin path and remove logs_path so default is used