Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.env.public approach to Makefile variables: quotes are literal in GNU Make #106

Open
zmughal opened this issue Apr 5, 2024 · 1 comment

Comments

@zmughal
Copy link

zmughal commented Apr 5, 2024

If the .env.public file is meant to be used as both a source-able .env file and as Makefile variables, it must use the intersection of their syntaxes which is stricter on special characters. For GNU Make, this means that any quotes (m/["']/) will be literal quotes in the GNU Make variable, but sh(1) will use the contents of the quoted string.

It might be better to treat it as just Makefile variables (e.g., config.Makefile) and apply the appropriate quoting in the GNU Make recipe commands.

Full details mentioned here: #95 (comment) (with a patch I do not like).

@noelmcloughlin
Copy link
Contributor

Hi @zmughal Sorry for delay. I think we could just do a PR to remove quotes from https://github.com/linkml/linkml-project-cookiecutter/blob/main/%7B%7Bcookiecutter.project_name%7D%7D/.env.public
They are not necessary for source-able .env file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants