From 6ff2c8489d6beb2d8ded47c27403f05bf06f4536 Mon Sep 17 00:00:00 2001 From: Oliver Gould Date: Sun, 25 Mar 2018 20:29:54 +0000 Subject: [PATCH] Skip flaky tests for #613 The metrics endpoint tests are flaky because there are no guarantees that the metrics pipeline has processed events before the metrics endpoint is read. This can cause CI to fail spuriously. Disable these tests from running in CI until #613 is resolved. --- proxy/tests/telemetry.rs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/proxy/tests/telemetry.rs b/proxy/tests/telemetry.rs index d9be08da1ce85..2b846f4ddedec 100644 --- a/proxy/tests/telemetry.rs +++ b/proxy/tests/telemetry.rs @@ -266,7 +266,9 @@ macro_rules! assert_contains { } } +// https://github.com/runconduit/conduit/issues/613 #[test] +#[cfg_attr(not(feature = "flaky_tests"), ignore)] fn metrics_endpoint_inbound_request_count() { let _ = env_logger::try_init(); @@ -295,7 +297,9 @@ fn metrics_endpoint_inbound_request_count() { } +// https://github.com/runconduit/conduit/issues/613 #[test] +#[cfg_attr(not(feature = "flaky_tests"), ignore)] fn metrics_endpoint_outbound_request_count() { let _ = env_logger::try_init(); @@ -502,7 +506,9 @@ fn metrics_endpoint_outbound_response_latency() { "response_latency_ms_count{authority=\"tele.test.svc.cluster.local\",direction=\"outbound\",status_code=\"200\"} 4"); } +// https://github.com/runconduit/conduit/issues/613 #[test] +#[cfg_attr(not(feature = "flaky_tests"), ignore)] fn metrics_endpoint_inbound_request_duration() { let _ = env_logger::try_init(); @@ -537,7 +543,9 @@ fn metrics_endpoint_inbound_request_duration() { "request_duration_ms_count{authority=\"tele.test.svc.cluster.local\",direction=\"inbound\"} 2"); } +// https://github.com/runconduit/conduit/issues/613 #[test] +#[cfg_attr(not(feature = "flaky_tests"), ignore)] fn metrics_endpoint_outbound_request_duration() { let _ = env_logger::try_init();