Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service topologies: Add node locality token to proxy-api protocol buffer #4500

Closed
mateiidavid opened this issue May 28, 2020 · 1 comment
Closed

Comments

@mateiidavid
Copy link
Member

Link to RFC

Problem Statement

In order to support service topology, the destination svc needs to know the source of the traffic. This is done through a node locality token, that is sent by the proxy as part of its Destination.Get call.

To support the extra field, the protocol buffer(s) in the proxy-api need to be changed to include the source node name.

Acceptance Criteria

  • Change destination.proto to include in Destination.Get the new source_node string field.
  • Re-generate client code for the gRPC bindings so that the source_node has all of its getter methods accessible by the destination svc
@mateiidavid
Copy link
Member Author

Closed by #4771

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants