Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular RBAC for metrics #3312

Open
grampelberg opened this issue Aug 22, 2019 · 5 comments
Open

Granular RBAC for metrics #3312

grampelberg opened this issue Aug 22, 2019 · 5 comments

Comments

@grampelberg
Copy link
Contributor

grampelberg commented Aug 22, 2019

Description

Introduce view isolation for metrics, defined by Kubernetes RBAC, to provide multi-tenancy to security conscious organizations. We previously have done this using an APIService for tap functionality.

The smi-metrics project already implements Linkerd metrics as an APIService. This has the added value of dogfooding smi-metrics and providing common tooling for other integrations in the future.

Details

@alenkacz
Copy link
Contributor

@grampelberg @admc could you please assign this to me? Thanks :)

@grampelberg
Copy link
Contributor Author

Note: it is probably worth using smi-metrics where it can be used and expanding the spec where it isn't usable instead of creating a new one-off APIService.

@PierrePIRONIN
Copy link

Hi ! I’m exactly in this use-case, do you currently work on it ? Thanks

@grampelberg
Copy link
Contributor Author

@PierrePIRONIN I believe that @alenkacz is currently looking into it. You can use smi-metrics as is to do something similar though.

@grampelberg grampelberg added the priority/P0 Release Blocker label Jan 9, 2020
@grampelberg grampelberg changed the title Granular RBAC for statistics Granular RBAC for metrics Jan 9, 2020
@grampelberg
Copy link
Contributor Author

Historical


What problem are you trying to solve?

Many organizations have teams sharing the same cluster which should not see each other's data (multi-tenant). This was addressed for tap as part of #2725. Now that it is possible to have granular, Kubernetes based RBAC policies for tap, statistics should provide a similar benefit.

How should the problem be solved?

  • Add smi-metrics-adapter to the install.
  • Move the CLI commands that rely on stats to use the adapter.
  • Move the dashboard's underlying stat implementation over to use the adapter.

Out of scope

  • Moving grafana over to the adapter.

@grampelberg grampelberg added this to the 2.8 milestone Jan 16, 2020
@grampelberg grampelberg removed this from the 2.8 milestone Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants