Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom ConfigMaps #2991

Closed
tobias-nawa opened this issue Jun 25, 2019 · 3 comments
Closed

Custom ConfigMaps #2991

tobias-nawa opened this issue Jun 25, 2019 · 3 comments

Comments

@tobias-nawa
Copy link

Feature Request

What problem are you trying to solve?

When running linkerd upgrade the ConfigMaps are part of the output. By using this output, all custom changes in the ConfigMaps are overwritten.

In my case I was changing the Grafana configuration to enable the login. After every upgrade the login is disabled again.

How should the problem be solved?

Maybe it's ok to not touch certain configurations, like the Grafana configuration which shouldn't change so often. But this is open for discussion.

Any alternatives you've considered?

Maybe a command like linkerd upgrade --no-configs grafana would work to exclude certain configurations.

How would users interact with this feature?

linkerd upgrade
or
linkerd upgrade --no-configs grafana

@ihcsim
Copy link
Contributor

ihcsim commented Jun 27, 2019

We should be able to do this by extending the --from-manifest option of the linkerd upgrade command to read the Grafana config map from a YAML file, generated from a previous installation. (See #2697). AFAICT, atm, the --from-manifest option only works for the linkerd-config config map, identity secret, and webhooks secrets.

@Bullettoothtobi Will this approach work for you?

@grampelberg
Copy link
Contributor

@Bullettoothtobi I just put some docs together around this, does linkerd/website#384 work for you?

@tobias-nawa
Copy link
Author

That's exactly what I needed! Thanks for your great work!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants