set connect timeout to a more reasonable value than 100ms #11
Conversation
…production when zk is deployed across datacenters and the client is talking to an observer (IMO this should be externalized for the client to set via command line arg)
|
Would definitely accept a pull request with the suggested externalized configuration ;) |
|
Please review and test, I ran |
|
It looks fine. Thank you. I can merge to trunk but I won't release it/bundle it for a while. Let me know if that works for you or if you are ok like this (since you already build it from source, you may not need to have it merged to trunk right away...). When I work on glu 5.0 which will be to upgrade pretty much everything to latest (including jdk7), I will definitely release it then. |
|
Thanks, this is an after the fact pull request we (Outbrain) already compiled glu with a version that has 10s as the timeout value and deployed to prod. I'm good with waiting for 5.0 |
…s in production when zk is deployed across datacenters and the client is talking to an observer (IMO this should be externalized for the client to set via command line arg)
|
Merged in 1.5.0 (will also be part of glu 4.7.0) |
...duction when zk is deployed across datacenters and the client is talking to an observer (IMO this should be externalized for the client to set via command line arg)