Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract sass type definitions to @types/node-sass. #198

Open
chriseppstein opened this issue Feb 7, 2019 · 1 comment
Open

Extract sass type definitions to @types/node-sass. #198

chriseppstein opened this issue Feb 7, 2019 · 1 comment
Labels
package:eyeglass Related to the core eyeglass package in this monorepo.

Comments

@chriseppstein
Copy link
Contributor

The type definition for node-sass required changes. We need to combine the types in SassImplementation with the main node-sass types and to reconcile this against the type definitions generated for dart-sass.
@chriseppstein chriseppstein mentioned this issue Feb 7, 2019
Merged
13 tasks
@chriseppstein
Copy link
Contributor Author

Note: SassError currently extends Error, it needn't define the message property again.

@chriseppstein chriseppstein mentioned this issue Feb 11, 2019
Merged
@chriseppstein chriseppstein added the package:eyeglass Related to the core eyeglass package in this monorepo. label Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:eyeglass Related to the core eyeglass package in this monorepo.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chriseppstein