Updates to make the tests pass. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, we'll do a fast follow on the travis build failing. It may have to do with the make jasmine not working, but at least the tests pass in the specRunner.html passes now, which is better than what we have. |
|
Just realized we probably don't need to bump the package number since nothing in the core helpers file actually changed, only tests changed. What do you think @jimmyhchan? |
|
No movement on this, so I would say just don't update the package number. |
| @@ -0,0 +1,503 @@ | |||
| // | |||
prashn64
added a commit
that referenced
this pull request
Nov 26, 2013
Updates to make the client tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.