Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @ne helper as the complement to the @eq helper #14

Merged
merged 4 commits into from
Sep 19, 2012
Merged

Add @ne helper as the complement to the @eq helper #14

merged 4 commits into from
Sep 19, 2012

Conversation

smfoote
Copy link
Contributor

@smfoote smfoote commented Sep 19, 2012

No description provided.

@vybs
Copy link
Contributor

vybs commented Sep 19, 2012

travis build failed @smfoote

also please make sure to pull this back into LI trunk today

@param type (optional), supported types are number, boolean, string, date, context, defaults to string
Note : use type="number" when comparing numeric
**/
"eq": function(chunk, context, bodies, params) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was it supposed to be called ne:)

unit tests please

expected: "not equal",
message: "ne helper non matching string case"
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a type parameter ( would suggest adding foe type="number" and few others i dont remember on the top of my head.. test cases for completion )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.
On Sep 19, 2012 11:52 AM, "Veena Basavaraj" [email protected]
wrote:

In test/jasmine-test/spec/helpersTests.js:

  • },
  • {
  • name: "ne helper matching string case",
  • source: "{@ne key="foo" value="foo"}not equal{/ne}",
  • context: {},
  • expected: "",
  • message: "ne helper matching string case"
  • },
  • {
  • name: "ne helper non matching string case",
  • source: "{@ne key="foo" value="bar"}not equal{:else}bar{/ne}",
  • context: {},
  • expected: "not equal",
  • message: "ne helper non matching string case"
  • },
  • {

there is a type parameter ( would suggest adding foe type="number" and few
others i dont remember on the top of my head.. test cases for completion )


Reply to this email directly or view it on GitHubhttps://github.com//pull/14/files#r1643419.

While adding tests, I discovered some problems with the filter and coerce functions. Fixes included here.
vybs added a commit that referenced this pull request Sep 19, 2012
Add @ne helper as the complement to the @eq helper
@vybs vybs merged commit db72dbf into master Sep 19, 2012
@sethkinast sethkinast deleted the ne branch November 12, 2014 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants