Don't require a key for {@select}
#133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everything deps #129 so ignore this until it goes in. |
|
Here's the one thing that I'm not certain on: Previously, if you had a key that wasn't defined, it wouldn't be coerced even if you set the type. But we've asked the helper to coerce to type string, so really |
|
+1 for the last comment, that's a legit use case and works better in this new world. |
Also allowed `type` to be set on the select instead of each truth test. If `type` is set both places, the value on the truth test will take precedence. Fixed coercion of undefined values. Previously, if a value was undefined it would not be coerced to the specified type.
sethkinast
force-pushed
the
select-no-key
branch
from
06b0972 to
fa6a8ea
Compare
sethkinast
added a commit
that referenced
this pull request
Apr 18, 2015
Don't require a key for `{@select}`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allowed
typeto be set on the select instead of each truth test. Iftypeis set both places, the value on the truth test will take precedence.Fixed coercion of undefined values. Previously, if a value was undefined it would not be coerced to the specified type.
Closes #123