Normalize all log messages. #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -191,7 +191,7 @@ | |||
| context: {}, | |||
| expected: "", | |||
| message: "math helper blah operation", | |||
| log: "{@math}: method blah not supported" | |||
| log: "Method `blah` is not supported" | |||
There was a problem hiding this comment.
Include the helper name prefix in the log check.
Log messages start with the name of the helper that generated them. Log messages start with a capital letter. Log messages do not end with punctuation. Log messages enclose parameter names in backticks. Log messages are tested.
sethkinast
force-pushed
the
log-language
branch
from
fc993be to
931569e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs describing something that did not execute are ERRORs.
Logs describing something that executed but with no effect are WARNs.
Log messages start with the name of the helper that generated them.
Log messages start with a capital letter.
Log messages do not end with punctuation.
Log messages enclose parameter names in backticks.
Log messages are tested.