Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSON-LD handler to fetcher #439

Merged
merged 6 commits into from
Oct 5, 2020
Merged

Add JSON-LD handler to fetcher #439

merged 6 commits into from
Oct 5, 2020

Conversation

michielbdejong
Copy link
Collaborator

No description provided.

@michielbdejong
Copy link
Collaborator Author

r? @angelo-v @timbl

@michielbdejong michielbdejong mentioned this pull request Sep 1, 2020
Closed
@michielbdejong michielbdejong requested a review from timbl September 1, 2020 11:01
angelo-v
angelo-v reviewed Sep 1, 2020
View reviewed changes
tests/unit/fetcher-jsonld-test.js Outdated Show resolved Hide resolved
src/fetcher.ts Show resolved Hide resolved
timbl
timbl requested changes Sep 1, 2020
View reviewed changes
Copy link
Member

@timbl timbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding -- I didn't realize it was missing!
One day we should add all the parser tests for each language to the rdflib test suite - though it would take a long time to run evrey time you check your code in.

tests/unit/fetcher-jsonld-test.js Outdated Show resolved Hide resolved
tests/unit/fetcher-test.js Outdated Show resolved Hide resolved
@michielbdejong michielbdejong merged commit 44f968a into master Oct 5, 2020
@michielbdejong michielbdejong mentioned this pull request Oct 5, 2020
Closed
@timea-solid timea-solid deleted the json-ld branch March 31, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelo-v angelo-v angelo-v left review comments

@timbl timbl timbl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michielbdejong @angelo-v @timbl