-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix circular dependency & expose a basic namespace map #240
base: main
Are you sure you want to change the base?
Conversation
Oh, I've caused a circular dependency |
95b05fd
to
7b4a799
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, only comment I have is that I think mostly the 2007 HTTP ontology is used in Solid, and personally, I prefer the dc prefix for dcterms. I'll let others decide whether to merge.
7b4a799
to
110a728
Compare
LGTM, can you resolve the conflict? |
It was using `ns` assuming it's available globally
110a728
to
746e15e
Compare
The conflict has been resolved, I've also added the LDP namespace which was missing The problem of Node#toJS was fixed in 62da35e, though that created a circular dependency by a top-level import of |
@megoth can you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think I'll request some changes now after all this time. I think the patch should be reviewed for consistency with https://github.com/solid/solid-namespace/blob/master/index.js and I think we should review the way we manage these maps, if that implies deprecating solid-namespace in favor doing it in rdflib like here, or if it should be split into modules of its own. But the first stage, IMHO, is to have consistency between this and solid-namespace.
The function was using a non-existent variable
ns
assuming it's available globally (which it might not).This was taken from the map from link, but adapted and extended with some of the larger vocabs from lov. Notice that map has been frozen to prevent (accidental) change in behaviour by external sources, which is omitted in this commit.
I was wondering whether the following addition would be useful as well;