Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review webextension-polyfill usages #70

Open
hugolpz opened this issue May 27, 2024 · 2 comments
Open

Review webextension-polyfill usages #70

hugolpz opened this issue May 27, 2024 · 2 comments
Assignees
Labels
feature New feature or request Purify Clean up code, remove obsolete, optimize
Milestone

Comments

@hugolpz
Copy link
Member

hugolpz commented May 27, 2024

As I dived back into the code and its maintenance I'm remembering of :

We have it installed in the packgage.json, but I think it is not properly imported accorss the web-extension.

Ways to load polyfill

See Basic Setup

  • In Manifest.json
  • In .js content scripts
  • In popup.html

Resources

@hugolpz hugolpz added feature New feature or request Purify Clean up code, remove obsolete, optimize labels May 27, 2024
@hugolpz hugolpz added this to the GSoC 2024 milestone May 27, 2024
@hugolpz hugolpz assigned hugolpz and unassigned kabir-afk May 27, 2024
@kabir-afk
Copy link
Collaborator

Well I can't seem to remember where I read it but as far as I remember...it was something about callbacks and promises with relation to previous manifest version (MV2). In MV2 chrome used callbacks while other browsers supported promises...but now that promise support is added , I said that the we no longer have to use webExtension polyfill API. But upon understanding more of the extension and reading more docs , I realized that we do need polyfills for cross browser compatibility.

As far as the issue is concerned then in the PR#63 I commnetd out the polyfill library inside my popup.js , so that might be the reason why it isn't imported properly.

@hugolpz hugolpz closed this as completed Jun 9, 2024
@hugolpz hugolpz reopened this Jun 9, 2024
@kabir-afk
Copy link
Collaborator

Can I mention one other thing ? When uncommenting the polyfill library inside popup.js , it throws error background page is missing or something like that. And this was also the reason I kept it commented out.

@hugolpz hugolpz modified the milestones: GSoC 2024, Fall 2024 Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request Purify Clean up code, remove obsolete, optimize
Projects
None yet
Development

No branches or pull requests

2 participants