linera-service: give ClientContext access to storage
#2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twey
changed the title
ClientContext: construct with access to storagelinera-service: give ClientContext access to storage
Twey
force-pushed
the
06-12-Client_context_storage
branch
2 times, most recently
from
f497736
to
2bf62be
Compare
Twey
force-pushed
the
06-12-Client_context_storage
branch
from
2bf62be
to
9900d04
Compare
jvff
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the future, the
ClientContextwill contain aClient, which needs to be constructed with access to aStorageinstance. However, currently theClientContextis constructed outside theJob, which is the only place theStorageis available.Proposal
Move the construction of the
ClientContextinto theJob, so it has access to storage.Test Plan
CI.
Release Plan
None required.
Links