RPC messages work on ConfirmedBlockCertificates #2976
+104
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afck
approved these changes
Nov 27, 2024
|
@afck In Ensure that we get correct number of certs in resposen. I made it so that we verify, after download, that we get exactly the certificates we requested and fail otherwise. Please double-check me here. |
afck
approved these changes
Nov 27, 2024
afck
reviewed
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
RpcMessage::DownloadCertificateResponseandRpcMessage::DownloadCertificatesResponsecontainCertificatetype.Proposal
Change to carry the
ConfirmedBlockCertificate.Test Plan
CI.
Release Plan
Links
Closes #2975