Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse, store and compare benchmark results in PRs #2923

Open
Tracked by #2833
ndr-ds opened this issue Nov 20, 2024 · 0 comments
Open
Tracked by #2833

Parse, store and compare benchmark results in PRs #2923

ndr-ds opened this issue Nov 20, 2024 · 0 comments
Assignees

Comments

@ndr-ds
Copy link
Contributor

ndr-ds commented Nov 20, 2024

Right now we don't run benchmarks on PRs, and we don't really look at the metrics for the ones running on main pushes either, AFAIK. We can probably expand the tool written in #2834 to also parse, store past results somewhere on main pushes, and on PRs parse and compare the benchmark results with the stored ones. And maybe also comment on the PR with the results.

Alternatively you can use this https://github.blog/news-insights/product-news/supercharging-github-actions-with-job-summaries/ to have a summary posted in the job run page, and just have a link to the latest benchmark job run in the PR comment, which will have the summary of the benchmark results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant