Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cairo backend extremely slow text hit test #222

Closed
ForLoveOfCats opened this issue Jun 29, 2020 · 2 comments
Closed

Cairo backend extremely slow text hit test #222

ForLoveOfCats opened this issue Jun 29, 2020 · 2 comments
Labels
perf performance related issue piet-cairo issue in the cairo backend

Comments

@ForLoveOfCats
Copy link
Collaborator

On wimpy system the following amount of text is enough to make dragging selection slow enough to lock up the UI for seconds at a time (due to performing a hit test on every mouse movement event).
image

Here is a perf recording showing that the issue resides within piet_cairo's hit test functionality
image

I'm aware that this entire codepath will soon/eventually die once we no longer use Cairo's toy text API for this backend but even if this is not fixed before that happens it is good to at least have it documented as an issue

@cmyr cmyr added perf performance related issue piet-cairo issue in the cairo backend labels Jul 4, 2020
@stuaxo
Copy link

stuaxo commented Jan 16, 2021

Is it worth using cairos own hit testing with cairo_in_fill or cairo_in_stroke ?

@ForLoveOfCats
Copy link
Collaborator Author

Fixed by #389, #425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf performance related issue piet-cairo issue in the cairo backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants