Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11 shell lacks menu support. #933

Open
luleyleo opened this issue May 15, 2020 · 4 comments
Open

X11 shell lacks menu support. #933

luleyleo opened this issue May 15, 2020 · 4 comments
Labels
discussion needs feedback and ideas help wanted has no one working on it yet missing a feature is missing on a specific platform shell/x11 concerns the X11 backend

Comments

@luleyleo
Copy link
Collaborator

luleyleo commented May 15, 2020

I'm not sure if X11 provides us anything, but as mentioned in #860 we will likely have to implement menus our selves.

@luleyleo luleyleo added help wanted has no one working on it yet discussion needs feedback and ideas shell/x11 concerns the X11 backend missing a feature is missing on a specific platform labels May 15, 2020
@luleyleo luleyleo changed the title X11 lacks menu support X11 shell lacks menu support May 15, 2020
@luleyleo luleyleo changed the title X11 shell lacks menu support X11 shell lacks menu support. May 15, 2020
@psychon
Copy link
Contributor

psychon commented Jun 19, 2020

From #599

menus: I think we're going to have to draw these ourselves for X11 (???).
There may be some other way to do it by requesting the window manager to do it
for you, but I didn't dig too deep into it yet. Suggestions welcome here.

Nope, you have to implement menus yourself in X11. Menus are windows with their override-redirect property set to true. This means that the window manager completely ignores these windows. Additionally, one usually grabs all input with a GrabPointer request, but I am not actually completely sure.

(File dialog support #936 falls in a similar category: BYOFD - bring your own file dialog)

@fxdave
Copy link

fxdave commented Dec 27, 2020

Another thing to consider:

Menus should be hidden when there is a global app menu like on mac or gnome-hud, unity, etc... on Linux.

@richard-uk1
Copy link
Collaborator

The wayland backend will need menus as well.

@cmyr
Copy link
Member

cmyr commented Jan 10, 2021

the wasm backend also needs a menus solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion needs feedback and ideas help wanted has no one working on it yet missing a feature is missing on a specific platform shell/x11 concerns the X11 backend
Projects
None yet
Development

No branches or pull requests

5 participants