Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use-gtk feature #604

Closed
cmyr opened this issue Mar 5, 2020 · 0 comments · Fixed by #611
Closed

Remove use-gtk feature #604

cmyr opened this issue Mar 5, 2020 · 0 comments · Fixed by #611
Labels
help wanted has no one working on it yet maintenance cleans up code or docs

Comments

@cmyr
Copy link
Member

cmyr commented Mar 5, 2020

The intent of this feature was to allow selectively using gtk on mac, which was specifically so that I could test the gtk backend without needing to boot linux.

Ultimately it's way easier for me to just run a VM than to maintain this feature, and it's an annoying burden, maintenance wise.

Removing this feature will involve\

  • removing it from the Cargo.toml (druid & druid-shell)
  • removing it anywhere it is used; we should use the gtk backend by default on linux, only swapping to the x11 backend when it is specified by feature;
  • and updating CI to no longer use this flag anywhere, if it is currently.

This should wait until #599 lands, otherwise it will be a painful merge.

@cmyr cmyr added help wanted has no one working on it yet maintenance cleans up code or docs labels Mar 5, 2020
@cmyr cmyr closed this as completed in #611 Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted has no one working on it yet maintenance cleans up code or docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant