Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a sane default minimum window size #1303

Closed
cmyr opened this issue Oct 12, 2020 · 3 comments · Fixed by #1438
Closed

Have a sane default minimum window size #1303

cmyr opened this issue Oct 12, 2020 · 3 comments · Fixed by #1438
Labels
D-Easy just needs to be implemented help wanted has no one working on it yet

Comments

@cmyr
Copy link
Member

cmyr commented Oct 12, 2020

Currently by default windows can be made arbitrarily small. I think there should be a default minimum size in the 400x400 range, and if you want your window to be resizeable below that you need to explicitly set the minimum size to something smaller, using WindowDesc::with_min_size.

Just as a note: you can set a minimum size for a window, and I think this should be set for most actual applications? I actually think this should have reasonable defaults, and if you want to be able to resize windows to be very small you should have to specify that manually, but that's also a separate issue. 😁

Originally posted by @cmyr in #1297 (comment)

@cmyr cmyr added D-Easy just needs to be implemented help wanted has no one working on it yet labels Oct 12, 2020
@totsteps
Copy link
Collaborator

totsteps commented Oct 15, 2020

I am in favor of adding a minimum default size to WindowConfig.

When adding a minimum size to a window config either via WindowConfig::default() or WindowConfig::with_min_size, I noticed a small issue with the launched window not respecting the minimum size!

Let's say I add a min-size of 600x600, whereas the launched window has a min-size of 500x400 on macOS!

@cmyr
Copy link
Member Author

cmyr commented Oct 15, 2020

@totsteps that sounds like a separate bug, would you like to open an issue for it?

@totsteps
Copy link
Collaborator

Filed in #1322.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-Easy just needs to be implemented help wanted has no one working on it yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants