Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label/button rendering issues on web #1265

Closed
JAicewizard opened this issue Sep 28, 2020 · 2 comments · Fixed by #1338
Closed

label/button rendering issues on web #1265

JAicewizard opened this issue Sep 28, 2020 · 2 comments · Fixed by #1338
Labels
piet requires fixes or changes in Piet shell/web concerns the web backend

Comments

@JAicewizard
Copy link
Contributor

On web the label/button text rendering is offset to the top. If the button is big it is not noticeable but if you resize the window to be small the text overflows the textbox.
There is also an issue in Piet that the colour (or any other attribute) is not settable, but that is not what this issue is about. Due to this it is hard to read the text.
misplaced_button_text
For context the top is the search-bar and bottom is dev tools slided up to make the window smaller artificially.
This is 1 window with 1 child widget, the Button.

@cmyr
Copy link
Member

cmyr commented Sep 28, 2020

See linebender/piet#311; there's some work that needs to be done in the piet-web backend.

@JAicewizard
Copy link
Contributor Author

ok nice, since there wasnt something a log entry (like attributes not being supported) I posted here, I guess we can keep this open until the piet issue is closed?

@cmyr cmyr added piet requires fixes or changes in Piet shell/web concerns the web backend labels Sep 28, 2020
@cmyr cmyr mentioned this issue Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
piet requires fixes or changes in Piet shell/web concerns the web backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants