Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace find references with custom logic #50

Merged
merged 123 commits into from
Nov 14, 2024

Conversation

kazushisan
Copy link
Contributor

this patch will replace use of ts.LanguageService.findReferences with custom logic

  • we should gain a ~2x performance gain (tested with benchmark/excalidraw.sh)
  • ts.LanguageService.findReferences was not sufficient enough for our use case. For example it does not report export * from './foo.js'; syntax, dynamic imports, etc. so we had to implement multiple workarounds. This change will streamline the logic and leaves room to implement features like remove unused exports when using import * as syntax #38

kazushisan and others added 30 commits November 14, 2024 17:39
@kazushisan kazushisan self-assigned this Nov 14, 2024
@kazushisan kazushisan merged commit 485daed into release/0.7.0 Nov 14, 2024
1 check passed
@kazushisan kazushisan deleted the feat/collect-usage branch November 14, 2024 09:17
@kazushisan
Copy link
Contributor Author

#41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant