-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation at the beginning of func:RandomSamplingWithPriority #496
Merged
Mdaiki0730
merged 5 commits into
Finschia:main
from
Mdaiki0730:main-fix-randomsampling-exception
Nov 11, 2022
Merged
Add validation at the beginning of func:RandomSamplingWithPriority #496
Mdaiki0730
merged 5 commits into
Finschia:main
from
Mdaiki0730:main-fix-randomsampling-exception
Nov 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mdaiki0730
added
the
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
label
Nov 11, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
==========================================
- Coverage 65.53% 65.44% -0.09%
==========================================
Files 278 278
Lines 37916 37936 +20
==========================================
- Hits 24847 24828 -19
- Misses 11264 11295 +31
- Partials 1805 1813 +8
|
tnasu
requested changes
Nov 11, 2022
ulbqb
reviewed
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about simple error messages?
tnasu
previously approved these changes
Nov 11, 2022
@ulbqb |
Mdaiki0730
force-pushed
the
main-fix-randomsampling-exception
branch
from
November 11, 2022 10:01
20fc42a
to
50dfb9a
Compare
tnasu
approved these changes
Nov 11, 2022
ulbqb
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think we need adding independent input validation of the parameters at the beginning of the function RandomSamplingWithPriority() instead of relying on the selection algorithm to validate them.
PR Check List